Inline remaining usages of OpenProcess on Unix#127795
Open
am11 wants to merge 5 commits intodotnet:mainfrom
Open
Inline remaining usages of OpenProcess on Unix#127795am11 wants to merge 5 commits intodotnet:mainfrom
am11 wants to merge 5 commits intodotnet:mainfrom
Conversation
jkotas
reviewed
May 5, 2026
jkotas
reviewed
May 5, 2026
jkotas
reviewed
May 5, 2026
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
janvorli
reviewed
May 5, 2026
This was referenced May 6, 2026
jkotas
reviewed
May 6, 2026
|
|
||
| #ifdef TARGET_UNIX | ||
| // JIT-attach via CreateProcess + waitable process handle is Windows-only. Returning a | ||
| // failing HRESULT lets the calling code fall back to the standard hosting failure path. |
Member
There was a problem hiding this comment.
What is the "standard hosting failure path" that this is talking about?
Member
Author
There was a problem hiding this comment.
Updated for clarification. It uses "no debugger attached" / unwind path on Unix.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two usages of OpenProcess and one of OpenProcessMemory.
Follow-up: #127604 (comment).