Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Metrics counterpart of System.Net EventCounters #88383

Open
antonfirsov opened this issue Jul 4, 2023 · 2 comments
Open

Implement the Metrics counterpart of System.Net EventCounters #88383

antonfirsov opened this issue Jul 4, 2023 · 2 comments

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Jul 4, 2023

Opening a separate issue for System.Net.NameResolution/Security/Socket specific parts of #79371. We should implement the Metrics counterpart of the events listed below.

I wasn't able to find any OTel specifications for this area, which would require us to change the semantics, so my assumption is that this should be fairly trivial work.

It might complicate things if we want to enable passing an IMeterFactory to Dns or Socket similarly to #86961, but that work can be done incrementally.

System.Net.NameResolution

All counters listed in https://learn.microsoft.com/en-us/dotnet/core/diagnostics/available-counters#systemnetnameresolution-counters

  • dns-lookups-requested
  • dns-lookups-duration
  • current-dns-lookups

Also tracked in #48885.

System.Net.Security

All counters listed in https://learn.microsoft.com/en-us/dotnet/core/diagnostics/available-counters#systemnetsecurity-counters:

  • tls-handshake-rate
  • total-tls-handshakes
  • current-tls-handshakes
  • failed-tls-handshakes
  • all-tls-sessions-open
  • tls10-sessions-open
  • tls11-sessions-open
  • tls12-sessions-open
  • tls13-sessions-open
  • all-tls-handshake-duration
  • tls10-handshake-duration
  • tls11-handshake-duration
  • tls12-handshake-duration
  • tls13-handshake-duration

System.Net.Sockets

All counters listed in https://learn.microsoft.com/en-us/dotnet/core/diagnostics/available-counters#systemnetsockets-counters

  • outgoing-connections-established
  • incoming-connections-established
  • current-outgoing-connect-attempts
  • bytes-received
  • bytes-sent
  • datagrams-received
  • datagrams-sent
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 4, 2023
@ghost
Copy link

ghost commented Jul 4, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Opening a separate issue for System.Net.NameResolution/Security/Socket specific parts of #79371. We should implement the Metrics counterpart of the events listed below.

I wasn't able to find any OTel specifications for this area, which would require us to change the semantics, so my assumption is that this should be fairly trivial work.

It might complicate things if we want to enable passing an IMeterFactory to Dns or Socket similarly to #86961, but that work can be done incrementally.

System.Net.NameResolution

All counters listed in https://learn.microsoft.com/en-us/dotnet/core/diagnostics/available-counters#systemnetnameresolution-counters

  • dns-lookups-requested
  • dns-lookups-duration
  • current-dns-lookups

System.Net.Security

All counters listed in https://learn.microsoft.com/en-us/dotnet/core/diagnostics/available-counters#systemnetsecurity-counters:

  • tls-handshake-rate
  • total-tls-handshakes
  • current-tls-handshakes
  • failed-tls-handshakes
  • all-tls-sessions-open
  • tls10-sessions-open
  • tls11-sessions-open
  • tls12-sessions-open
  • tls13-sessions-open
  • all-tls-handshake-duration
  • tls10-handshake-duration
  • tls11-handshake-duration
  • tls12-handshake-duration
  • tls13-handshake-duration

System.Net.Sockets

All counters listed in https://learn.microsoft.com/en-us/dotnet/core/diagnostics/available-counters#systemnetsockets-counters

  • outgoing-connections-established
  • incoming-connections-established
  • current-outgoing-connect-attempts
  • bytes-received
  • bytes-sent
  • datagrams-received
  • datagrams-sent
Author: antonfirsov
Assignees: -
Labels:

area-System.Net

Milestone: -

@tarekgh
Copy link
Member

tarekgh commented Jul 4, 2023

@antonfirsov if you are planning to address this in .NET 8.0, please mark it as so for easier tracking. Thanks!

CC @karelz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants