Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RuntimeAsync] Implement struct async thunks. #3011

Open
VSadov opened this issue Feb 19, 2025 · 0 comments
Open

[RuntimeAsync] Implement struct async thunks. #3011

VSadov opened this issue Feb 19, 2025 · 0 comments

Comments

@VSadov
Copy link
Member

VSadov commented Feb 19, 2025

Re: https://github.com/dotnet/runtimelab/pull/2951/files#r1960790542

There is an assert:

       // Struct async thunks not yet implemented
       _ASSERTE(!this->GetMethodTable()->IsValueType());

It can be hit by Async2Struct testcase by changing the void Async() entry point to be an ordinary async method.

      private static async Task Async()    // not async2

Some of the scenarios in the test may become irrelevant since it will be C# responsibility to capture by value.

However the general case of an async struct method still needs to be handled, so this needs a follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant