Exclude generated files from compilation by default #77325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
dotnet-policy-service
bot
added
the
Community
Youssef1313
reviewed
Feb 24, 2025
jaredpar
requested changes
Feb 24, 2025
|
it is about overall experience. this uses default location (obj/somewhere/) which is excluded <PropertyGroup>
<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
</PropertyGroup>with custom location <PropertyGroup>
<EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
<CompilerGeneratedFilesOutputPath>mylocation</CompilerGeneratedFilesOutputPath>
</PropertyGroup>we have duplicate definition error. is that the intended experience? if so, quite strange! |
|
In this case though you're using a custom location which is part of the included paths searched for source files. My push back is why are you doing that? This is a documented location that the compiler searches for source files. There are plenty of other tasks in the sdk that generate code, or even content, and none of them are being pushed to be excluded in this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set ExcludeGeneratedFilesFromCompilation to true by default if not explicitly specified by updating Microsoft.CSharp.Core.targets to automatically exclude all .cs files in CompilerGeneratedFilesOutputPath.
This prevents duplicate type definitions and build errors when running dotnet build multiple times.
Fix dotnet/sdk#47046