Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent2 Window Style Missing Setters #10452

Open
robert-abeo opened this issue Feb 12, 2025 · 0 comments
Open

Fluent2 Window Style Missing Setters #10452

robert-abeo opened this issue Feb 12, 2025 · 0 comments
Assignees
Labels
Investigate Requires further investigation by the WPF team. Win 11 Theming

Comments

@robert-abeo
Copy link

Description

The Fluent2 Window Style is missing a few very important setters. I suspect some of them might be on purpose but it still should be discussed:

  • Background
  • FontFamily, FontSize

Reproduction Steps

See current default control style:

https://github.com/dotnet/wpf/blob/main/src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Window.xaml

Expected behavior

The following should be set to ensure the application follows upstream Fluent2 theme.

The window Background should be using the pre-existing WindowBackground resource instead of Transaparent.

I realize font-related properties may intentionally NOT be set so the UI is more similar to Aero2 and older themes for compatibility with existing apps. However, I would still argue the font family/size is important to the Fluent look-and-feel and we should set these by default. Apps can disable them if desired.

        <Setter Property="Background" Value="{DynamicResource WindowBackground}" />
        <Setter Property="FontFamily" Value="{DynamicResource ContentControlThemeFontFamily}" />
        <Setter Property="FontSize" Value="{DynamicResource ControlContentThemeFontSize}" />

Actual behavior

Properties are not set

Regression?

No response

Known Workarounds

No response

Impact

No response

Configuration

No response

Other information

No response

@siagupta0202 siagupta0202 added Win 11 Theming Investigate Requires further investigation by the WPF team. labels Feb 14, 2025
@siagupta0202 siagupta0202 self-assigned this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigate Requires further investigation by the WPF team. Win 11 Theming
Projects
Status: No status
Development

No branches or pull requests

2 participants