Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent2 ToolTip Missing Some Lightweight Styling Resources Available in WinUI3 #9671

Open
robert-abeo opened this issue Aug 29, 2024 · 0 comments
Assignees
Labels
Bug Product bug (most likely) Investigate Requires further investigation by the WPF team. Win 11 Theming

Comments

@robert-abeo
Copy link

Description

Fluent2's ToolTip is missing some lightweight styling resource that can be used to change common properties without re-templating. WPF just hardcodes these values. This is especially problematic for padding which is set across two different controls in the template instead of just one as per the standard.

Reproduction Steps

See current code with hard-coded values:

Expected behavior

WPF's Fluent2 implementation should follow upstream WinUI3 for ALL resources to ensure compatibility. This is a big task to review and align all the resource keys but I think it's needed.

See upstream:

https://github.com/microsoft/microsoft-ui-xaml/blob/aeed4c19e2fc7c2c093216a51b651f2f0890c930/src/controls/dev/CommonStyles/ToolTip_themeresources.xaml#L76-L77

Actual behavior

WPF's Fluent2 implementation has hardcoded values it shouldn't.

Regression?

No response

Known Workarounds

No response

Impact

No response

Configuration

No response

Other information

No response

@himgoyalmicro himgoyalmicro added Bug Product bug (most likely) Investigate Requires further investigation by the WPF team. labels Aug 30, 2024
@harshit7962 harshit7962 self-assigned this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Product bug (most likely) Investigate Requires further investigation by the WPF team. Win 11 Theming
Projects
None yet
Development

No branches or pull requests

4 participants