[HC-015] Hard cutover shared helper hoist across compiler, runtime, scripts, and tests

[doublemover]

Hard cutover policy: repeated helper implementations are hoisted to shared modules. No local static reimplementations of common behavior remain in parser, sema, IR, pipeline, runtime, scripts, or tests.

Source facts already established:

• Parser, semantic, IR, pipeline, runtime, and scripts repeatedly build normalized selectors, profile strings, JSON fragments, diagnostic text, stable sorted lists, source paths, command output, artifact paths, and AST walks.
• io/objc3_json.h exists, while other modules still concatenate JSON manually.
• Runtime acceptance and workflow scripts duplicate subprocess, progress, report, and artifact handling.

Required native shared tree:

• native/objc3c/src/support/text/
  • join.h/.cpp
  • case_convert.h/.cpp
  • string_escape.h/.cpp
• native/objc3c/src/support/selectors/
  • selector_normalization.h/.cpp
  • method_family.h/.cpp
• native/objc3c/src/support/source/
  • source_location.h/.cpp
  • source_range_format.h/.cpp
• native/objc3c/src/support/ast_walk/
  • expr_walk.h/.cpp
  • stmt_walk.h/.cpp
  • decl_walk.h/.cpp
• native/objc3c/src/support/stable_order/
  • stable_sort.h/.cpp
  • deterministic_key.h/.cpp
• native/objc3c/src/support/identifiers/
  • safe_suffix.h/.cpp
  • symbol_names.h/.cpp
• native/objc3c/src/io/json/
  • json_value.h/.cpp
  • json_writer.h/.cpp
  • json_parser.h/.cpp
• native/objc3c/src/io/process/
  • process_command.h/.cpp
  • process_result.h/.cpp
• native/objc3c/src/io/filesystem/
  • path_normalization.h/.cpp
  • artifact_paths.h/.cpp

Required Python shared tree:

• scripts/objc3c_shared/
  • commands.py
  • artifacts.py
  • json_io.py
  • progress.py
  • fixtures.py
  • schemas.py
  • paths.py
  • hashing.py

Required work:

• Replace local static helpers with shared helpers from the trees above.
• Delete manual JSON parser and writer fragments outside shared JSON modules.
• Delete duplicate subprocess wrappers in workflow and acceptance scripts.
• Delete duplicate fixture discovery and schema validation helpers.
• Delete duplicate selector normalization and method-family helpers.
• Delete duplicate AST traversal collectors across semantic feature summaries.
• Add dependency-boundary tests that prevent helper code from drifting back into feature modules.

Maximum effort shared hoist pass:

• Perform a complete dedupe pass across every file touched by HC-003 through HC-014.
• Hoist shared code to the narrowest common owner.
• Prefer domain-level shared modules over global support modules for domain-specific behavior.
• Add tests for every hoisted helper.

Acceptance criteria:

• rg "EscapeJsonString|BuildNormalizedObjcSelector|JoinStringVector|Collect.*FromExpr|Collect.*FromStatement|subprocess.run|json.dumps|ProcessStartInfo" native scripts tests shows shared helper usage or approved shared module definitions only.
• Dependency-boundary tests fail on new local helper clones.
• Shared helper modules have focused unit tests.
• Feature modules contain feature behavior, not common plumbing.

[doublemover]

Current checkout evaluation after the hard-cutover integration commits: PARTIAL, keep open.

Landed work:

• Shared helper surfaces now exist for workflow commands/reports, runtime acceptance reports, native JSON, and Python JSON/subprocess tooling.
• Source hygiene and workflow code reuse improved compared with the pre-integration tree.

Remaining blockers from the current checkout:

• scripts/objc3c_workflow/runner.py is still 2,396 lines.
• A broad helper audit still finds many direct json.dumps, json.dump, and subprocess.run call sites outside the shared helper modules.
• Native code still has manual JSON writing and EscapeJsonString usage in tool/driver surfaces.

This should close only after duplicate helper logic is actually hoisted or explicitly classified as allowed, with the remaining call sites covered by shared APIs.

[doublemover]

Checkpoint pushed: 7feae24ac and ac31f1519.

Shared helper hoist progress:

• Runtime acceptance artifact registry behavior moved from core.py into scripts/objc3c_runtime_acceptance/artifacts.py.
• Deterministic Python JSON IO moved into scripts/objc3c_shared/json_io.py; scripts/objc3c_tooling/json_io.py now routes callers through the shared implementation.
• Schema lookup/validation helpers were strengthened in scripts/objc3c_shared/schema_registry.py.
• Report envelope validation was strengthened in scripts/objc3c_shared/report_model.py.
• Capability support-claim validation was centralized in scripts/validate_capability_docs.py instead of relying on local docs text checks.

Validation:

• python scripts/check_objc3c_runtime_acceptance.py --case artifact-registry-key-isolation PASS
• python scripts/check_objc3c_tooling_helpers.py PASS
• $env:PYTHONPATH='scripts'; python -m pytest tests/tooling/test_objc3c_shared_json_schema.py tests/tooling/test_capability_docs_validator.py -q PASS (13 passed)
• npm run objc3c -- lint PASS

Keeping this open. These are real hoists, but the issue still needs the remaining duplicated compiler/runtime/script/test helpers removed or routed through owning shared modules.

[doublemover]

Hard-cutover shared-helper checkpoint (May 6, 2026): landed and pushed dccdcc77b (HC-012 extract runtime acceptance progress reporter).

Completed in this checkpoint:

• Hoisted runtime-acceptance progress, elapsed-time formatting, command rendering, and repo-relative path display helpers out of scripts/objc3c_runtime_acceptance/core.py.
• Added the dedicated helper owner scripts/objc3c_runtime_acceptance/progress.py and switched harness.py to import/re-export from that owner.

Validation run:

• python -m py_compile scripts/objc3c_runtime_acceptance/progress.py scripts/objc3c_runtime_acceptance/core.py scripts/objc3c_runtime_acceptance/harness.py
• python scripts/check_objc3c_runtime_acceptance.py --case artifact-registry-key-isolation
• python -m scripts.source_hygiene
• npm run objc3c -- lint
• git diff --cached --check

Current closure status: still open. This retires one runtime helper cluster from the giant core, but #8146 still needs the remaining duplicated helper clusters across compiler/runtime/scripts/tests to be assigned to durable owners before final closure.

[doublemover]

Shared-helper hard-cutover checkpoint (May 6, 2026): landed and pushed ffe19ddf1 (HC-012 own runtime acceptance probe helpers).

Completed in this checkpoint:

• Assigned runtime acceptance command execution to scripts/objc3c_runtime_acceptance/commands.py instead of keeping the progress-aware runner embedded in core.py.
• Assigned probe compile/run/retry helpers to scripts/objc3c_runtime_acceptance/probes.py instead of re-exporting them from core.py.
• Assigned mutable progress state to scripts/objc3c_runtime_acceptance/progress.py via explicit getter/setter ownership.

Validation run:

• python -m py_compile scripts/objc3c_runtime_acceptance/progress.py scripts/objc3c_runtime_acceptance/commands.py scripts/objc3c_runtime_acceptance/probes.py scripts/objc3c_runtime_acceptance/core.py scripts/objc3c_runtime_acceptance/harness.py
• python scripts/check_objc3c_runtime_acceptance.py --case installation-lifecycle
• python -m scripts.source_hygiene
• git diff --check

Current closure status: still open. This removes another helper cluster from core.py, but #8146 still needs the remaining duplicated helper clusters across compiler/runtime/scripts/tests moved to durable owners before closure.

[doublemover]

Shared-helper checkpoint (May 6, 2026): landed and pushed 893a4af12 and 7130e36f3.

Completed in 893a4af12:

• Moved runtime acceptance assertion/checksum/replay helpers into dedicated helper owners.
• Moved native build/fixture/provenance helpers out of the runtime acceptance core module.
• Hoisted inspect-validation-timing workflow implementation into scripts/objc3c_workflow/actions/validation_timing.py while keeping the public action name unchanged.

Completed in 7130e36f3:

• Tightened public C API owned/borrowed string comments and immutability in the C API result/string/version surface.

Validation evidence:

• Runtime acceptance py_compile and four-case runtime acceptance run passed.
• npm run objc3c -- inspect-validation-timing passed for the workflow hoist.
• C API smoke tests passed: tests/tooling/test_objc3c_c_api_smoke.py 5 passed, 2 skipped; tests/tooling/test_objc3c_frontend_library_entrypoint_extraction.py 3 passed.
• python -m scripts.source_hygiene PASS, active_findings 0.

Current closure status: still open. More shared-helper clusters remain, including schema/JSON helper migration and remaining workflow/native helper surfaces.

[doublemover]

Pushed checkpoint 7b2c532. Documentation and public-command workflow actions moved out of scripts/objc3c_workflow/runner.py into scripts/objc3c_workflow/actions/docs.py while keeping npm run objc3c -- behavior intact. Validation evidence: py_compile for runner/actions docs passed; npm run objc3c -- check-public-command-budget passed; git diff --check passed. #8146 remains open for the remaining runner decomposition and hygiene closure mechanics.

[doublemover]

Pushed checkpoint 685aa63. Native build/package/proof workflow adapters were extracted from scripts/objc3c_workflow/runner.py into scripts/objc3c_workflow/actions/native_build.py, preserving the public ACTION_HANDLERS names. Validation evidence: python -m py_compile scripts/objc3c_workflow/runner.py scripts/objc3c_workflow/actions/native_build.py passed; npm run objc3c -- check-public-command-budget passed; git diff --cached --check passed. #8146 remains open for the remaining runner action clusters.