simple workflows + testing infra

Signed-off-by: Kostas Kyrimis <[email protected]>

Author: kostasrim

.github/actions/regression-tests/action.yml

@@ -31,6 +31,9 @@ inputs:
   epoll:
     required: false
     type: string
+  df-arg:
+    required: false
+    type: string
 
 runs:
   using: "composite"
@@ -55,14 +58,18 @@ runs:
         export ROOT_DIR="${GITHUB_WORKSPACE}/tests/dragonfly/valkey_search"
         export UBSAN_OPTIONS=print_stacktrace=1:halt_on_error=1 # to crash on errors
 
+        if [[ "${{inputs.df-arg}}" == 'epoll' ]]; then
+          export DF_ARG="--df ${{inputs.df-arg}}"
+        fi
+
         if [[ "${{inputs.epoll}}" == 'epoll' ]]; then
           export FILTER="${{inputs.filter}} and not exclude_epoll"
           # Run only replication tests with epoll
-          timeout 80m pytest -m "$FILTER" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --df force_epoll=true --log-cli-level=INFO || code=$?
+          timeout 80m pytest -m "$FILTER" $DF_ARG --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --df force_epoll=true --df --log-cli-level=INFO || code=$?
         else
           export FILTER="${{inputs.filter}}"
           # Run only replication tests with iouring
-          timeout 80m pytest -m "$FILTER" --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --log-cli-level=INFO || code=$?
+          timeout 80m pytest -m "$FILTER" $DF_ARG --durations=10 --timeout=300 --color=yes --json-report --json-report-file=report.json dragonfly --log-cli-level=INFO || code=$?
         fi
 
         # timeout returns 124 if we exceeded the timeout duration

.github/workflows/ioloop-v2-regtests.yml

@@ -0,0 +1,80 @@
+name: RegTests IoLoopV2
+
+# Manually triggered only
+on:
+  workflow_dispatch:
+
+jobs:
+  build:
+    strategy:
+      matrix:
+        # Test of these containers
+        container: ["ubuntu-dev:20"]
+        proactor: [Uring]
+        build-type: [Debug, Release]
+        runner: [ubuntu-latest, [self-hosted, linux, ARM64]]
+
+    runs-on: ${{ matrix.runner }}
+
+    container:
+      image: ghcr.io/romange/${{ matrix.container }}
+      options: --security-opt seccomp=unconfined --sysctl "net.ipv6.conf.all.disable_ipv6=0"
+      volumes:
+        - /var/crash:/var/crash
+
+    steps:
+      - uses: actions/checkout@v5
+        with:
+          submodules: true
+
+      - name: Print environment info
+        run: |
+          cat /proc/cpuinfo
+          ulimit -a
+          env
+
+      - name: Configure & Build
+        run: |
+          # -no-pie to disable address randomization so we could symbolize stacktraces
+          cmake -B ${GITHUB_WORKSPACE}/build -DCMAKE_BUILD_TYPE=${{matrix.build-type}} -GNinja \
+                -DCMAKE_CXX_COMPILER_LAUNCHER=ccache -DPRINT_STACKTRACES_ON_SIGNAL=ON \
+                -DCMAKE_CXX_FLAGS=-no-pie -DHELIO_STACK_CHECK:STRING=4096
+
+          cd ${GITHUB_WORKSPACE}/build  && ninja dragonfly
+          pwd
+          ls -l ..
+
+      - name: Run regression tests action
+        uses: ./.github/actions/regression-tests
+        with:
+          dfly-executable: dragonfly
+          gspace-secret: ${{ secrets.GSPACES_BOT_DF_BUILD }}
+          build-folder-name: build
+          filter: ${{ matrix.build-type == 'Release' && 'not debug_only and not tls' || 'not opt_only and not tls' }}
+          aws-access-key-id: ${{ secrets.AWS_S3_ACCESS_KEY }}
+          aws-secret-access-key: ${{ secrets.AWS_S3_ACCESS_SECRET }}
+          s3-bucket: ${{ secrets.S3_REGTEST_BUCKET }}
+          df-arg: "expiremental_io_loop_v2"
+
+      - name: Upload logs on failure
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: logs
+          path: /tmp/failed/*
+
+      - name: Copy binary on a self hosted runner
+        if: failure()
+        run: |
+          # We must use sh syntax.
+          if [ "$RUNNER_ENVIRONMENT" = "self-hosted" ]; then
+            cd ${GITHUB_WORKSPACE}/build
+            timestamp=$(date +%Y-%m-%d_%H:%M:%S)
+            mv ./dragonfly /var/crash/dragonfy_${timestamp}
+          fi
+
+  lint-test-chart:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+      - uses: ./.github/actions/lint-test-chart

tests/dragonfly/connection_test.py

@@ -875,6 +875,7 @@ async def check_stats():
     await check_stats()
 
 
+@pytest.mark.tls
 async def test_reject_non_tls_connections_on_tls(with_tls_server_args, df_factory):
     server: DflyInstance = df_factory.create(
         no_tls_on_admin_port="true",
@@ -894,6 +895,7 @@ async def test_reject_non_tls_connections_on_tls(with_tls_server_args, df_factor
     assert await client.dbsize() == 0
 
 
+@pytest.mark.tls
 async def test_tls_insecure(with_ca_tls_server_args, with_tls_client_args, df_factory):
     server = df_factory.create(port=BASE_PORT, **with_ca_tls_server_args)
     server.start()
@@ -902,6 +904,7 @@ async def test_tls_insecure(with_ca_tls_server_args, with_tls_client_args, df_fa
     assert await client.dbsize() == 0
 
 
+@pytest.mark.tls
 async def test_tls_full_auth(with_ca_tls_server_args, with_ca_tls_client_args, df_factory):
     server = df_factory.create(port=BASE_PORT, **with_ca_tls_server_args)
     server.start()
@@ -910,6 +913,7 @@ async def test_tls_full_auth(with_ca_tls_server_args, with_ca_tls_client_args, d
     assert await client.dbsize() == 0
 
 
+@pytest.mark.tls
 async def test_tls_reject(
     with_ca_tls_server_args, with_tls_client_args, df_factory: DflyInstanceFactory
 ):
@@ -1094,6 +1098,7 @@ async def client_pause():
     await all
 
 
+@pytest.mark.tls
 async def test_tls_when_read_write_is_interleaved(
     with_ca_tls_server_args, with_ca_tls_client_args, df_factory
 ):
@@ -1371,6 +1376,7 @@ async def test_client_detached_crash(df_factory):
     server.stop()
 
 
+@pytest.mark.tls
 async def test_tls_client_kill_preemption(
     with_ca_tls_server_args, with_ca_tls_client_args, df_factory
 ):

tests/dragonfly/instance.py

@@ -436,8 +436,6 @@ def create(self, existing_port=None, path=None, version=100, **kwargs) -> DflyIn
         if version >= 1.26:
             args.setdefault("fiber_safety_margin=4096")
 
-        args.setdefault("expiremental_io_loop_v2=true")
-
         for k, v in args.items():
             args[k] = v.format(**self.params.env) if isinstance(v, str) else v
 

tests/dragonfly/pymemcached_test.py

@@ -176,6 +176,7 @@ def test_expiration(memcached_client: MCClient):
     assert memcached_client.get("key3") == None
 
 
+@pytest.mark.tls
 @dfly_args(DEFAULT_ARGS)
 def test_memcached_tls_no_requirepass(df_factory, with_tls_server_args, with_tls_ca_cert_args):
     """

tests/dragonfly/replication_test.py

@@ -1447,6 +1447,7 @@ async def test_take_over_timeout(df_factory, df_seeder_factory):
 replication_cases = [(8, 8)]
 
 
+@pytest.mark.tls
 @pytest.mark.parametrize("t_master, t_replica", replication_cases)
 async def test_no_tls_on_admin_port(
     df_factory: DflyInstanceFactory,
@@ -1495,6 +1496,7 @@ async def test_no_tls_on_admin_port(
 replication_cases = [(8, 8, False), (8, 8, True)]
 
 
+@pytest.mark.tls
 @pytest.mark.parametrize("t_master, t_replica, test_admin_port", replication_cases)
 async def test_tls_replication(
     df_factory,
@@ -1559,6 +1561,7 @@ async def test_tls_replication(
     await proxy.close(proxy_task)
 
 
+@pytest.mark.tls
 @dfly_args({"proactor_threads": 2})
 async def test_tls_replication_without_ca(
     df_factory,

tests/dragonfly/tls_conf_test.py

@@ -4,20 +4,23 @@
 from .instance import DflyStartException
 
 
+@pytest.mark.tls
 async def test_tls_no_auth(df_factory, with_tls_server_args):
     # Needs some authentication
     server = df_factory.create(**with_tls_server_args)
     with pytest.raises(DflyStartException):
         server.start()
 
 
+@pytest.mark.tls
 async def test_tls_no_key(df_factory):
     # Needs a private key and certificate.
     server = df_factory.create(tls=None, requirepass="XXX")
     with pytest.raises(DflyStartException):
         server.start()
 
 
+@pytest.mark.tls
 async def test_tls_password(df_factory, with_tls_server_args, with_tls_ca_cert_args):
     with df_factory.create(requirepass="XXX", **with_tls_server_args) as server:
         async with server.client(
@@ -26,6 +29,7 @@ async def test_tls_password(df_factory, with_tls_server_args, with_tls_ca_cert_a
             await client.ping()
 
 
+@pytest.mark.tls
 async def test_tls_client_certs(
     df_factory, with_ca_tls_server_args, with_tls_client_args, with_tls_ca_cert_args
 ):
@@ -36,24 +40,28 @@ async def test_tls_client_certs(
             await client.ping()
 
 
+@pytest.mark.tls
 async def test_client_tls_no_auth(df_factory):
     server = df_factory.create(tls_replication=None)
     with pytest.raises(DflyStartException):
         server.start()
 
 
+@pytest.mark.tls
 async def test_client_tls_password(df_factory):
     with df_factory.create(tls_replication=None, masterauth="XXX"):
         pass
 
 
+@pytest.mark.tls
 async def test_client_tls_cert(df_factory, with_tls_server_args):
     key_args = with_tls_server_args.copy()
     key_args.pop("tls")
     with df_factory.create(tls_replication=None, **key_args):
         pass
 
 
+@pytest.mark.tls
 async def test_config_enable_tls_with_ca_dir(
     df_factory, with_ca_dir_tls_server_args, with_tls_client_args
 ):
@@ -67,6 +75,7 @@ async def test_config_enable_tls_with_ca_dir(
             assert res == "44"
 
 
+@pytest.mark.tls
 async def test_config_update_tls_certs(
     df_factory, with_tls_server_args, with_tls_ca_cert_args, tmp_dir
 ):
@@ -112,6 +121,7 @@ async def test_config_update_tls_certs(
             await client.ping()
 
 
+@pytest.mark.tls
 async def test_config_enable_tls(
     df_factory, with_ca_tls_server_args, with_tls_client_args, with_tls_ca_cert_args
 ):
@@ -152,6 +162,7 @@ async def test_config_enable_tls(
             await client_tls.ping()
 
 
+@pytest.mark.tls
 async def test_config_disable_tls(
     df_factory, with_ca_tls_server_args, with_tls_client_args, with_tls_ca_cert_args
 ):

tests/pytest.ini

@@ -19,5 +19,7 @@ markers =
 # Tests that should only run in debug mode because release builds are fast enough
 # for their assertions to hold. They never run on release build.
   debug_only: mark tests that should run only in debug mode
+#tls tests
+  tls: tests specific to tls
 filterwarnings =
     ignore::DeprecationWarning