Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests with with -race flag and fix race conditions #31

Closed
CluEleSsUK opened this issue Jul 7, 2022 · 1 comment
Closed

Run tests with with -race flag and fix race conditions #31

CluEleSsUK opened this issue Jul 7, 2022 · 1 comment

Comments

@CluEleSsUK
Copy link

While replacing circle CI with github actions, @AnomalRoil suggested running the go test runner with the race flag to check for race conditions. This identified some race conditions in DKG code that require investigation and remediating.

During prior investigation, a data access races were identified in the StatusMatrix struct implementation. Adding some generic RW locking worked fine on my local machine and the tests (including race condition testing) passed successfully.
On the github actions runner however the TestProtoFull test in proto_test.go appeared to suffer deadlock (albeit the go runtime did not detect this). Note: this deadlock does not happen without the -lock flag

Some attempts I tried to remedy this:

@AnomalRoil
Copy link
Member

I think this was fixed in #34 in the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants