You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While replacing circle CI with github actions, @AnomalRoil suggested running the go test runner with the race flag to check for race conditions. This identified some race conditions in DKG code that require investigation and remediating.
During prior investigation, a data access races were identified in the StatusMatrix struct implementation. Adding some generic RW locking worked fine on my local machine and the tests (including race condition testing) passed successfully.
On the github actions runner however the TestProtoFull test in proto_test.go appeared to suffer deadlock (albeit the go runtime did not detect this). Note: this deadlock does not happen without the -lock flag
While replacing circle CI with github actions, @AnomalRoil suggested running the go test runner with the
race
flag to check for race conditions. This identified some race conditions in DKG code that require investigation and remediating.During prior investigation, a data access races were identified in the
StatusMatrix
struct implementation. Adding some generic RW locking worked fine on my local machine and the tests (including race condition testing) passed successfully.On the github actions runner however the
TestProtoFull
test inproto_test.go
appeared to suffer deadlock (albeit the go runtime did not detect this). Note: this deadlock does not happen without the-lock
flagSome attempts I tried to remedy this:
resCh
inTestProtoFull
buffer size to 0 and 2 (see testing: go 1.17 regression: deadlock in test suite golang/go#48402)StatusMatrix
withRWLock
and vanillaLock
The text was updated successfully, but these errors were encountered: