DX-114802: Support Jira tickets in PR titles

Author: timhurskidremio

.github/workflows/dev_pr.js

@@ -122,15 +122,20 @@ module.exports = {
         const title = context.payload.pull_request.title;
         if (title.startsWith("MINOR: ")) {
             console.log("PR is a minor PR");
-            return {"issue": null};
+            return {"issue": null, "type": "minor"};
         }
 
-        const match = title.match(/^GH-([0-9]+): .*$/);
+        const match = title.match(/^(GH|DX)-([0-9]+): .*$/);
         if (match === null) {
-            core.setFailed("Invalid PR title format. Must either be MINOR: or GH-NNN:");
-            return {"issue": null};
+            core.setFailed("Invalid PR title format. Must either be MINOR:, GH-NNN:, or DX-NNN:");
+            return {"issue": null, "type": null};
         }
-        return {"issue": parseInt(match[1], 10)};
+
+        const issueType = match[1]; // "GH" or "DX"
+        const issueNumber = parseInt(match[2], 10);
+
+        console.log(`PR references ${issueType}-${issueNumber}`);
+        return {"issue": issueNumber, "type": issueType};
     },
 
     apply_labels: async function({core, github, context}) {
@@ -203,9 +208,28 @@ See [CONTRIBUTING.md](https://github.com/apache/arrow-java/blob/main/CONTRIBUTIN
             console.log("This is a MINOR PR");
             return;
         }
-        const expected = `https://github.com/apache/arrow-java/issues/${issue.issue}`;
 
-        const query = `
+        // Handle Jira tickets (DX-NNN)
+        if (issue.type === "DX") {
+            const jiraUrl = `https://dremio.atlassian.net/browse/DX-${issue.issue}`;
+            console.log(`This PR references Jira ticket: ${jiraUrl}`);
+
+            // Add a comment with the Jira link
+            const comment_tag = "jira_link_comment";
+            const maybe_comment_id = await have_comment(github, context, context.payload.pull_request.number, comment_tag);
+            const body_text = `<!-- ${comment_tag} -->
+**Related Jira Ticket:** [DX-${issue.issue}](${jiraUrl})`;
+
+            await upsert_comment(github, maybe_comment_id, body_text, true);
+            console.log("Added/updated Jira link comment");
+            return;
+        }
+
+        // Handle GitHub issues (GH-NNN)
+        if (issue.type === "GH") {
+            const expected = `https://github.com/apache/arrow-java/issues/${issue.issue}`;
+
+            const query = `
 query($owner: String!, $name: String!, $number: Int!) {
   repository(owner: $owner, name: $name) {
     pullRequest(number: $number) {
@@ -220,22 +244,23 @@ query($owner: String!, $name: String!, $number: Int!) {
   }
 }`;
 
-        const result = await github.graphql(query, {
-            owner: context.repo.owner,
-            name: context.repo.repo,
-            number: context.payload.pull_request.number,
-        });
-        const issues = result.repository.pullRequest.closingIssuesReferences.edges;
-        console.log(issues);
-
-        for (const link of issues) {
-            console.log(`PR is linked to ${link.node.number}`);
-            if (link.node.number === issue.issue) {
-                console.log(`Found link to ${expected}`);
-                return;
+            const result = await github.graphql(query, {
+                owner: context.repo.owner,
+                name: context.repo.repo,
+                number: context.payload.pull_request.number,
+            });
+            const issues = result.repository.pullRequest.closingIssuesReferences.edges;
+            console.log(issues);
+
+            for (const link of issues) {
+                console.log(`PR is linked to ${link.node.number}`);
+                if (link.node.number === issue.issue) {
+                    console.log(`Found link to ${expected}`);
+                    return;
+                }
             }
+            console.log(`Did not find link to ${expected}`);
+            core.setFailed("Missing link to issue in title");
         }
-        console.log(`Did not find link to ${expected}`);
-        core.setFailed("Missing link to issue in title");
     },
 };

ci/scripts/jni_manylinux_build.sh

@@ -25,6 +25,22 @@ set -euo pipefail
 # shellcheck source=ci/scripts/util_log.sh
 . "$(dirname "${0}")/util_log.sh"
 
+github_actions_group_begin "Update llvm"
+    vcpkg install \
+        --debug \
+        --clean-after-build \
+        --x-install-root=${VCPKG_ROOT}/installed \
+        --x-manifest-root=/arrow/ci/vcpkg \
+        --overlay-ports=/arrow/ci/vcpkg/overlay/llvm/ \
+        --x-feature=dev \
+        --x-feature=flight \
+        --x-feature=gcs \
+        --x-feature=json \
+        --x-feature=parquet \
+        --x-feature=gandiva \
+        --x-feature=s3
+github_actions_group_end
+
 github_actions_group_begin "Prepare arguments"
 source_dir="$(cd "${1}" && pwd)"
 arrow_dir="$(cd "${2}" && pwd)"
@@ -57,7 +73,7 @@ devtoolset_version="$(rpm -qa "devtoolset-*-gcc" --queryformat '%{VERSION}' | gr
 devtoolset_include_cpp="/opt/rh/devtoolset-${devtoolset_version}/root/usr/include/c++/${devtoolset_version}"
 : "${ARROW_ACERO:=ON}"
 export ARROW_ACERO
-: "${ARROW_BUILD_TESTS:=ON}"
+: "${ARROW_BUILD_TESTS:=OFF}"
 export ARROW_BUILD_TESTS
 : "${ARROW_DATASET:=ON}"
 export ARROW_DATASET

vector/src/main/codegen/templates/UnionListWriter.java

@@ -53,6 +53,7 @@ public class Union${listName}Writer extends AbstractFieldWriter {
   private boolean inStruct = false;
   private boolean listStarted = false;
   private String structName;
+  private ArrowType extensionType;
   <#if listName == "LargeList" || listName == "LargeListView">
   private static final long OFFSET_WIDTH = 8;
   <#else>
@@ -203,13 +204,13 @@ public MapWriter map(String name, boolean keysSorted) {
 
   @Override
   public ExtensionWriter extension(ArrowType arrowType) {
-    writer.extension(arrowType);
-    return writer;
+    extensionType = arrowType;
+    return this;
   }
+
   @Override
   public ExtensionWriter extension(String name, ArrowType arrowType) {
-    ExtensionWriter extensionWriter = writer.extension(name, arrowType);
-    return extensionWriter;
+    return writer.extension(name, arrowType);
   }
 
   <#if listName == "LargeList">
@@ -336,14 +337,18 @@ public void writeNull() {
 
   @Override
   public void writeExtension(Object value) {
-    writer.writeExtension(value);
+    writer.writeExtension(value, extensionType);
+    writer.setPosition(writer.idx() + 1);
   }
+  
   @Override
-  public void addExtensionTypeWriterFactory(ExtensionTypeWriterFactory var1) {
-    writer.addExtensionTypeWriterFactory(var1);
+  public void writeExtension(Object value, ArrowType type) {
+    writeExtension(value);
   }
+  
   public void write(ExtensionHolder var1) {
     writer.write(var1);
+    writer.setPosition(writer.idx() + 1);
   }
 
   <#list vv.types as type>