-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin 2.1.20 #457
base: main
Are you sure you want to change the base?
Kotlin 2.1.20 #457
Conversation
Would you be up for cutting a preview release of this branch for other projects testing 2.1.20? |
Do you need this branch specifically or is forward compatibility with 2.1.20-Beta1 sufficient? I.e. does the current snapshot work for you? |
My understanding from #455 was that the latest release doesn't work with the 2.1.20-Beta1 compiler? |
ohhh I missed the reflection PR. That might work, though a non-snapshot release is always nicer for reproducible builds |
Yep just making sure it had what you need before cutting a release. 0.18.2 release is in progress now. |
* Swap CI sample test order * Reverse compat irCall logic
ecae4b1
to
2ada5fa
Compare
2ada5fa
to
670d584
Compare
Looks like with 2.1.20-Beta2, all code is compiled into the Kotlin/JS executable, not just the classes used in |
Filter down to a single non-data class to check for THROW_CCE code
// Hack to filter out data classes, which do have the `THROW_CCE` code: | ||
val intAndLongLines = javascript.split("\n").filter { it.contains("IntAndLong") } | ||
assertAll { | ||
assertThat( | ||
actual = intAndLongLines.filter { it.contains("other instanceof IntAndLong") }, | ||
).hasSize(1) | ||
|
||
assertThat( | ||
actual = intAndLongLines.filter { it.contains("THROW_CCE") }, | ||
).isEmpty() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less hacky workaround ideas welcome!
…with 2.1.0 and 2.1.10
Closes #455.