Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 2.1.20 #457

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Kotlin 2.1.20 #457

wants to merge 4 commits into from

Conversation

drewhamilton
Copy link
Owner

Closes #455.

@ZacSweers
Copy link

Would you be up for cutting a preview release of this branch for other projects testing 2.1.20?

@drewhamilton
Copy link
Owner Author

Do you need this branch specifically or is forward compatibility with 2.1.20-Beta1 sufficient? I.e. does the current snapshot work for you?

@ZacSweers
Copy link

My understanding from #455 was that the latest release doesn't work with the 2.1.20-Beta1 compiler?

@ZacSweers
Copy link

ohhh I missed the reflection PR. That might work, though a non-snapshot release is always nicer for reproducible builds

@drewhamilton
Copy link
Owner Author

Yep just making sure it had what you need before cutting a release. 0.18.2 release is in progress now.

* Swap CI sample test order
* Reverse compat irCall logic
@drewhamilton
Copy link
Owner Author

Looks like with 2.1.20-Beta2, all code is compiled into the Kotlin/JS executable, not just the classes used in fun main. This breaks the test added in #228 because it pulls in compiled data classes, which don't have the same performance enhancement.

Filter down to a single non-data class to check for THROW_CCE code
Comment on lines +12 to +21
// Hack to filter out data classes, which do have the `THROW_CCE` code:
val intAndLongLines = javascript.split("\n").filter { it.contains("IntAndLong") }
assertAll {
assertThat(
actual = intAndLongLines.filter { it.contains("other instanceof IntAndLong") },
).hasSize(1)

assertThat(
actual = intAndLongLines.filter { it.contains("THROW_CCE") },
).isEmpty()
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less hacky workaround ideas welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin 2.1.20 support
2 participants