Skip to content

Commit 240846c

Browse files
committed
Fixing issue 2202465.
1 parent 04e2a93 commit 240846c

11 files changed

+558
-183
lines changed

css/ec-index.css

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
ul.index-dialog-links, ul.index-dialog-links li {
2+
list-style-type: none;
3+
}
4+
ul.index-dialog-links li, ul.index-dialog-links li a {
5+
display: inline;
6+
}
7+
8+
ul.index-dialog-links li.active, ul.index-dialog-links li a.active {
9+
color: #0074BD;
10+
}
11+
12+
ul.index-dialog-links a {
13+
padding-left: 20px;
14+
margin: 5px;
15+
}
16+
17+
ul.index-dialog-links li a {
18+
background: url('../img/plus.png') left no-repeat;
19+
}
20+
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<?php
2+
3+
/**
4+
* @file
5+
* Template file for page that is used in our references dialog.
6+
*/
7+
?>
8+
<div id="elasticsearch-connector-dialog-page">
9+
<?php if (isset($messages)): print $messages; endif; ?>
10+
<?php print render($page['content']); ?>
11+
</div>

elasticsearch_connector.admin.inc

+9-5
Original file line numberDiff line numberDiff line change
@@ -414,9 +414,6 @@ function elasticsearch_connector_cluster_indices_add($form, &$form_state, $clust
414414
'#description' => t('Enter the number of shards replicas.')
415415
);
416416

417-
// TODO: Add other options if necessary at later stage.
418-
419-
420417
$form['actions'] = array(
421418
'#type' => 'actions',
422419
);
@@ -442,7 +439,7 @@ function elasticsearch_connector_cluster_indices_add_validate($form, &$form_stat
442439
form_set_error('index_name', t('Enter an index name that begins with a letter and contains only letters, numbers, and underscores.'));
443440
}
444441

445-
if (!is_numeric($values['num_of_shards'])) {
442+
if (!is_numeric($values['num_of_shards']) || $values['num_of_shards'] < 1) {
446443
form_set_error('num_of_shards', t('Invalid number of shards.'));
447444
}
448445

@@ -458,7 +455,8 @@ function elasticsearch_connector_cluster_indices_add_validate($form, &$form_stat
458455
*/
459456
function elasticsearch_connector_cluster_indices_add_submit($form, &$form_state) {
460457
$values = $form_state['values'];
461-
$client = elasticsearch_connector_load_library($form['#cluster']);
458+
$cluster = $form['#cluster'];
459+
$client = elasticsearch_connector_load_library($cluster);
462460
if ($client) {
463461
try {
464462
$index_params['index'] = $values['index_name'];
@@ -471,6 +469,12 @@ function elasticsearch_connector_cluster_indices_add_submit($form, &$form_state)
471469
else {
472470
drupal_set_message(t('Fail to create the index %index', array('%index' => $values['index_name'])), 'error');
473471
}
472+
473+
// If the form has been opened in dialog, close the window if it was
474+
// setup to do so.
475+
if (elasticsearch_connector_in_dialog() && elasticsearch_connector_close_on_submit()) {
476+
elasticsearch_connector_close_on_redirect($cluster->cluster_id, $values['index_name']);
477+
}
474478
}
475479
catch (Exception $e) {
476480
drupal_set_message($e->getMessage(), 'error');

0 commit comments

Comments
 (0)