Issue #2512008 by a_thakur: Fix the typo and make an update hook to fix the roles

Author: AshishThakur

elasticsearch_connector.install

@@ -119,3 +119,17 @@ function elasticsearch_connector_schema() {
 function elasticsearch_connector_uninstall() {
   variable_del('elasticsearch_connector_get_default_connector');
 }
+
+/**
+ * Implements hook_update_N().
+ *
+ * Update permissions.
+ */
+function elasticsearch_connector_update_7100(&$sandbox) {
+  db_update('role_permission')
+    ->fields(array(
+      'permission' => 'administer elasticsearch connector',
+    ))
+    ->condition('permission', 'adminiser elasticsearch connector')
+    ->execute();
+}

elasticsearch_connector.module

@@ -40,11 +40,10 @@ function elasticsearch_connector_cron() {
  * Implements hook_permission().
  */
 function elasticsearch_connector_permission() {
-  // TODO: Fix the typo and make an update hook to fix the roles.
   return array(
-    'adminiser elasticsearch connector' => array(
+    'administer elasticsearch connector' => array(
       'title' => t('Administer elasticsearch connector'),
-      'description' => t('Giving you access to administer elasticsearch clusters.'),
+      'description' => t('Provide access to administer elasticsearch clusters.'),
     ),
   );
 }
@@ -72,7 +71,7 @@ function elasticsearch_connector_menu() {
     'title'              => 'Elasticsearch connector',
     'description'        => 'Administer Elasticsearch connector module',
     'position'           => 'left',
-    'access arguments'   => array('adminiser elasticsearch connector'),
+    'access arguments'   => array('administer elasticsearch connector'),
     'page callback'      => 'system_admin_menu_block_page',
     'file'               => 'system.admin.inc',
     'file path'          => drupal_get_path('module', 'system'),
@@ -82,7 +81,7 @@ function elasticsearch_connector_menu() {
     'title'             => 'Elasticsearch Clusters',
     'description'       => 'Showing all available clusters',
     'page callback'     => 'elasticsearch_connector_status_page',
-    'access arguments'  => array('adminiser elasticsearch connector'),
+    'access arguments'  => array('administer elasticsearch connector'),
     'file'              => 'elasticsearch_connector.admin.inc',
     'weight'            => -10,
   );
@@ -92,7 +91,7 @@ function elasticsearch_connector_menu() {
     'description'        => 'Add new elasticsearch cluster',
     'page callback'      => 'drupal_get_form',
     'page arguments'     => array('elasticsearch_connector_edit_cluster'),
-    'access arguments'   => array('adminiser elasticsearch connector'),
+    'access arguments'   => array('administer elasticsearch connector'),
     'file'               => 'elasticsearch_connector.admin.inc',
     'type'               => MENU_LOCAL_ACTION,
   );
@@ -102,7 +101,7 @@ function elasticsearch_connector_menu() {
     'description'        => 'Edit cluster settings',
     'page callback'      => 'drupal_get_form',
     'page arguments'     => array('elasticsearch_connector_edit_cluster', 4),
-    'access arguments'   => array('adminiser elasticsearch connector'),
+    'access arguments'   => array('administer elasticsearch connector'),
     'file'               => 'elasticsearch_connector.admin.inc',
     'type'               => MENU_CALLBACK,
   );
@@ -112,7 +111,7 @@ function elasticsearch_connector_menu() {
     'description'        => 'Elasticsearch cluster info',
     'page callback'      => 'elasticsearch_connector_info_cluster',
     'page arguments'     => array(4),
-    'access arguments'   => array('adminiser elasticsearch connector'),
+    'access arguments'   => array('administer elasticsearch connector'),
     'file'               => 'elasticsearch_connector.admin.inc',
     'type'               => MENU_CALLBACK,
   );
@@ -122,7 +121,7 @@ function elasticsearch_connector_menu() {
     'description'        => 'Elasticsearch cluster indices',
     'page callback'      => 'elasticsearch_connector_cluster_indices',
     'page arguments'     => array(4),
-    'access arguments'   => array('adminiser elasticsearch connector'),
+    'access arguments'   => array('administer elasticsearch connector'),
     'file'               => 'elasticsearch_connector.admin.inc',
   );
 
@@ -131,7 +130,7 @@ function elasticsearch_connector_menu() {
     'description'        => 'Add index',
     'page callback'      => 'drupal_get_form',
     'page arguments'     => array('elasticsearch_connector_cluster_indices_add', 4),
-    'access arguments'   => array('adminiser elasticsearch connector'),
+    'access arguments'   => array('administer elasticsearch connector'),
     'file'               => 'elasticsearch_connector.admin.inc',
     'type'               => MENU_LOCAL_ACTION,
   );
@@ -141,7 +140,7 @@ function elasticsearch_connector_menu() {
     'description'        => 'Elasticsearch cluster indices',
     'page callback'      => 'drupal_get_form',
     'page arguments'     => array('elasticsearch_connector_cluster_indices_add', 4, 6),
-    'access arguments'   => array('adminiser elasticsearch connector'),
+    'access arguments'   => array('administer elasticsearch connector'),
     'load arguments'     => array('%map', '%index'),
     'file'               => 'elasticsearch_connector.admin.inc',
   );
@@ -151,7 +150,7 @@ function elasticsearch_connector_menu() {
     'description'        => 'Elasticsearch cluster indices',
     'page callback'      => 'elasticsearch_connector_cluster_indices_aliases',
     'page arguments'     => array(4, 6),
-    'access arguments'   => array('adminiser elasticsearch connector'),
+    'access arguments'   => array('administer elasticsearch connector'),
     'file'               => 'elasticsearch_connector.admin.inc',
   );
 
@@ -160,7 +159,7 @@ function elasticsearch_connector_menu() {
     'description'        => 'Elasticsearch cluster indices',
     'page callback'      => 'drupal_get_form',
     'page arguments'     => array('elasticsearch_connector_cluster_indices_delete', 4, 6),
-    'access arguments'   => array('adminiser elasticsearch connector'),
+    'access arguments'   => array('administer elasticsearch connector'),
     'file'               => 'elasticsearch_connector.admin.inc',
   );
 
@@ -169,14 +168,14 @@ function elasticsearch_connector_menu() {
     'description'        => 'Delete cluster settings',
     'page callback'      => 'drupal_get_form',
     'page arguments'     => array('elasticsearch_connector_delete_cluster', 4),
-    'access arguments'   => array('adminiser elasticsearch connector'),
+    'access arguments'   => array('administer elasticsearch connector'),
     'file'               => 'elasticsearch_connector.admin.inc',
   );
 
   $items['elasticsearch-connector-dialog/redirect/%elasticsearch_connector_cluster/%elasticsearch_connector_index_valid'] = array(
     'page callback' => 'elasticsearch_connector_redirect_page',
     'page arguments' => array(2, 3),
-    'access arguments' => array('adminiser elasticsearch connector'),
+    'access arguments' => array('administer elasticsearch connector'),
   );
 
   return $items;

modules/elasticsearch_connector_sequence/elasticsearch_connector_sequence.module

@@ -18,7 +18,7 @@ function elasticsearch_connector_sequence_menu() {
     'description'       => 'Setup the sequence module settings.',
     'page callback'      => 'drupal_get_form',
     'page arguments'     => array('elasticsearch_connector_sequence_settings'),
-    'access arguments'  => array('adminiser elasticsearch connector'),
+    'access arguments'  => array('administer elasticsearch connector'),
     'file'              => 'elasticsearch_connector_sequence.admin.inc',
   );
 

modules/elasticsearch_watchdog/elasticsearch_watchdog.module

@@ -37,7 +37,7 @@ function elasticsearch_watchdog_menu() {
     'description'       => 'Showing all available clusters',
     'page callback'      => 'drupal_get_form',
     'page arguments'     => array('elasticsearch_watchdog_settings'),
-    'access arguments'  => array('adminiser elasticsearch connector'),
+    'access arguments'  => array('administer elasticsearch connector'),
     'file'              => 'elasticsearch_watchdog.admin.inc',
   );