Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New parameter productcoveredbysa : Command proposal #2040

Closed
sara921-spec opened this issue Aug 2, 2024 · 2 comments · Fixed by #2044
Closed

New parameter productcoveredbysa : Command proposal #2040

sara921-spec opened this issue Aug 2, 2024 · 2 comments · Fixed by #2044
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@sara921-spec
Copy link
Contributor

sara921-spec commented Aug 2, 2024 •
edited
Loading

Command proposal

A new installation parameter, /PRODUCTCOVEREDBYSA, was introduced in SQL Server 2022 (16.x). This parameter indicates whether the provided product key (/PID=) license is covered under a Software Assurance or SQL Server Subscription contract, or just a SQL Server license.

image

Proposed parameters

Parameter Mandatory Data type Description Default value Allowed values
productcoveredbysa yes String Detailed description None true,False

"PRODUCTCOVEREDBYSA"

Special considerations or limitations

We have the new parameter "PRODUCTCOVEREDBYSA" available for "Install-SqlDscResource" but currently there is no resource using that command and this is to add the parameter to the DSC resource "DSC_SqlSetup" for the SQL 2022 installs.

SqlServerDsc-16.6.0\source\DSCResources\DSC_SqlSetup

#1798
@sara921-spec sara921-spec changed the title Command proposal New parameter productcoveredbysa : Command proposal Aug 2, 2024
@sara921-spec
Copy link
Contributor Author

Documentation : https://learn.microsoft.com/en-us/sql/database-engine/install-windows/install-sql-server-from-the-command-prompt?view=sql-server-ver16

@johlju
Copy link
Member

johlju commented Aug 2, 2024

Suggest we add a boolean parameter ProductCoveredBySA to the existing logic in the resource SqlSetup. I think this should be fairly easy to add for someone in the community.

Note

Suggest not use the new command Install-SqlDscServer as that would be a much larger undertaking, one that work was started for in PR #1912 but was not completed.

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Aug 2, 2024
@johlju johlju mentioned this issue Aug 27, 2024
Merged
9 tasks
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added New parameter ProductCoveredbySA that is introduced in SQL 2022 sara921-spec/SqlServerDsc
2 participants
@johlju @sara921-spec