Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get-SqlDscRSSetupConfiguration: Add function to retrieve Report Server setup configuration #2074

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Get-SqlDscRSSetupConfiguration: Add function to retrieve Report Server setup configuration #2074

wants to merge 31 commits into from
+1,281 −31

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 8, 2025 •
edited
Loading

Pull Request (PR) description

  • Public commands:
    • Get-SqlDscInstalledInstance to retrieve installed SQL instances.
    • Get-SqlDscRSSetupConfiguration to retrieve the setup configuration of
      SQL Server Reporting Services or Power BI Report Server (issue #2072).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner March 8, 2025 14:27
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (cbb005b) to head (ab66036).

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2074   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files       101     103    +2     
  Lines      8013    8083   +70     
====================================
+ Hits       7586    7656   +70     
  Misses      427     427
Flag Coverage Δ
unit 94% <100%> (+<1%) ⬆️
Files with missing lines Coverage Δ
source/Public/Get-SqlDscInstalledInstance.ps1 100% <100%> (ø)
source/Public/Get-SqlDscRSSetupConfiguration.ps1 100% <100%> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johlju johlju added the needs review The pull request needs a code review. label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-SqlDscRSSetupConfiguration: New command proposal
1 participant
@johlju