Skip to content

Commit 5cf4de3

Browse files
dtsongclaude
andcommitted
fix: add CI comment for profile flag and normalize conn string defaults
- Add comment explaining why --profile full is needed (ClickHouse is profile-gated; only explicitly named services start) - Add `or None` to Databricks and MsSQL conn strings to handle empty env vars consistently with all other optional databases Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent c3d3026 commit 5cf4de3

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ jobs:
4242
run: uv tool run ty check --python-version 3.10
4343

4444
- name: Build the stack
45+
# --profile full unlocks profile-gated clickhouse; only named services start
4546
run: docker compose --profile full up -d --wait mysql postgres clickhouse
4647

4748
- name: Run tests

tests/common.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727
TEST_BIGQUERY_CONN_STRING: str = os.environ.get("DATADIFF_BIGQUERY_URI") or None
2828
TEST_REDSHIFT_CONN_STRING: str = os.environ.get("DATADIFF_REDSHIFT_URI") or None
2929
TEST_ORACLE_CONN_STRING: str = None
30-
TEST_DATABRICKS_CONN_STRING: str = os.environ.get("DATADIFF_DATABRICKS_URI")
30+
TEST_DATABRICKS_CONN_STRING: str = os.environ.get("DATADIFF_DATABRICKS_URI") or None
3131
TEST_TRINO_CONN_STRING: str = os.environ.get("DATADIFF_TRINO_URI") or None
3232
TEST_CLICKHOUSE_CONN_STRING: str = os.environ.get("DATADIFF_CLICKHOUSE_URI") or None
3333
TEST_VERTICA_CONN_STRING: str = os.environ.get("DATADIFF_VERTICA_URI") or None
3434
TEST_DUCKDB_CONN_STRING: str = "duckdb://main:@:memory:"
35-
TEST_MSSQL_CONN_STRING: str = os.environ.get("DATADIFF_MSSQL_URI")
35+
TEST_MSSQL_CONN_STRING: str = os.environ.get("DATADIFF_MSSQL_URI") or None
3636

3737

3838
DEFAULT_N_SAMPLES = 50

0 commit comments

Comments
 (0)