Skip to content

Security: Remove hardcoded TrustServerCertificate in MSSQL driver #2

@dtsong

Description

@dtsong

Problem

data_diff/databases/mssql.py:181 hardcodes TrustServerCertificate=yes, which disables certificate validation for all MSSQL connections.

Impact

This is a security concern — it makes all MSSQL connections vulnerable to MITM attacks.

Suggested Fix

Make certificate validation configurable via connection parameters, defaulting to secure behavior.

References

  • File: data_diff/databases/mssql.py, line 181

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions