Skip to content

Commit 16a947e

Browse files
authored
GHA: fix duplicate step id (#5273)
Task/Issue URL: https://app.asana.com/0/inbox/1157893581871899/1208764131137352/1208764131137354 ### Description Fix duplicate ids and fastlane config for deployment --- - To see the specific tasks where the Asana app for GitHub is being used, see below: - https://app.asana.com/0/0/1208764131137352
1 parent 0e35d75 commit 16a947e

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

.github/workflows/release_upload_play_store.yml

+3-9
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
destination-path: $HOME/jenkins_static/com.duckduckgo.mobile.android/
6464

6565
- name: Assemble the bundle
66-
run: ./gradleW bundleRelease -PuseUploadSigning
66+
run: ./gradlew bundleRelease -PuseUploadSigning
6767

6868
- name: Capture App Bundle Path
6969
id: capture_output
@@ -72,21 +72,15 @@ jobs:
7272
echo "bundle_path=$output" >> $GITHUB_OUTPUT
7373
7474
- name: Upload bundle to Play Store
75-
id: create_app_bundle
75+
id: upload_bundle_play
7676
run: |
7777
bundle exec fastlane deploy_playstore
7878
7979
- name: Upload Universal APK to Github
80-
id: create_app_bundle
80+
id: upload_bundle_github
8181
run: |
8282
bundle exec fastlane deploy_github
8383
84-
- name: Upload APK as artifact
85-
uses: actions/upload-artifact@v4
86-
with:
87-
name: duckduckgo-${{ steps.generate_version_name.outputs.version }}.apk
88-
path: duckduckgo.apk
89-
9084
- name: Create Asana task when workflow failed
9185
if: ${{ failure() }}
9286
uses: duckduckgo/[email protected]

fastlane/Fastfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ platform :android do
209209
version = props["VERSION"]
210210
releaseNotes = release_notes_github()
211211
apkPath = "app/build/outputs/apk/play/release/duckduckgo-#{version}-play-release.apk"
212-
token = ENV["GITHUB_UPLOAD_TOKEN"]
212+
token = ENV["GH_TOKEN"]
213213

214214
UI.message ("Upload new app version to GitHub\nVersion: #{version}\nRelease Notes:\n=====\n#{releaseNotes}\n=====\n")
215215

0 commit comments

Comments
 (0)