Skip to content

Commit 4b3fb20

Browse files
authored
Reduce the high-count buckets (#5457)
Task/Issue URL: https://app.asana.com/0/1207418217763355/1208798050088814/f ### Description This PR removes the temporary high-count buckets from a tab-count pixel so that the highest one is 81+, as agreed in the privacy review.
1 parent 1eed968 commit 4b3fb20

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed

app/src/main/java/com/duckduckgo/app/tabs/store/TabStatsBucketing.kt

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,7 @@ interface TabStatsBucketing {
4646
21..40,
4747
41..60,
4848
61..80,
49-
81..100,
50-
101..125,
51-
126..150,
52-
151..250,
53-
251..500,
54-
501..Int.MAX_VALUE,
49+
81..Int.MAX_VALUE,
5550
)
5651

5752
val ACTIVITY_BUCKETS = listOf(

app/src/test/java/com/duckduckgo/app/tabs/store/TabStatsBucketingTest.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -94,42 +94,42 @@ class DefaultTabStatsBucketingTest {
9494
fun testGetNumberOfOpenTabs81To100() = runTest {
9595
whenever(tabRepository.getOpenTabCount()).thenReturn(90)
9696
val result = defaultTabStatsBucketing.getNumberOfOpenTabs()
97-
assertEquals("81-100", result)
97+
assertEquals("81+", result)
9898
}
9999

100100
@Test
101101
fun testGetNumberOfOpenTabs101To125() = runTest {
102102
whenever(tabRepository.getOpenTabCount()).thenReturn(110)
103103
val result = defaultTabStatsBucketing.getNumberOfOpenTabs()
104-
assertEquals("101-125", result)
104+
assertEquals("81+", result)
105105
}
106106

107107
@Test
108108
fun testGetNumberOfOpenTabs126To150() = runTest {
109109
whenever(tabRepository.getOpenTabCount()).thenReturn(130)
110110
val result = defaultTabStatsBucketing.getNumberOfOpenTabs()
111-
assertEquals("126-150", result)
111+
assertEquals("81+", result)
112112
}
113113

114114
@Test
115115
fun testGetNumberOfOpenTabs151To250() = runTest {
116116
whenever(tabRepository.getOpenTabCount()).thenReturn(200)
117117
val result = defaultTabStatsBucketing.getNumberOfOpenTabs()
118-
assertEquals("151-250", result)
118+
assertEquals("81+", result)
119119
}
120120

121121
@Test
122122
fun testGetNumberOfOpenTabs251To500() = runTest {
123123
whenever(tabRepository.getOpenTabCount()).thenReturn(300)
124124
val result = defaultTabStatsBucketing.getNumberOfOpenTabs()
125-
assertEquals("251-500", result)
125+
assertEquals("81+", result)
126126
}
127127

128128
@Test
129129
fun testGetNumberOfOpenTabsMaxValue() = runTest {
130130
whenever(tabRepository.getOpenTabCount()).thenReturn(600)
131131
val result = defaultTabStatsBucketing.getNumberOfOpenTabs()
132-
assertEquals("501+", result)
132+
assertEquals("81+", result)
133133
}
134134

135135
@Test

0 commit comments

Comments
 (0)