Onboarding: Added onboarding active check to New Tab Page (#5849)

Task/Issue URL:
https://app.asana.com/0/1201807753394693/1209870056514404/f

### Description
Added a check for onboarding active in order to show the new tab page

### Steps to test this PR

_Existing user_
- [x] Add some favorites
- [x] Install from branch
- [x] Check favorites still appear in new tab page

_New user_

- [x] Fresh install
- [x] Don't skip onboarding
- [x] Add favorites before finishing onboarding
- [x] finish onboarding
- [x] Check favorites appear

### No UI changes

Author: nalcalag

app/src/main/java/com/duckduckgo/app/cta/ui/CtaViewModel.kt

@@ -368,15 +368,15 @@ class CtaViewModel @Inject constructor(
     suspend fun areBubbleDaxDialogsCompleted(): Boolean {
         return withContext(dispatchers.io()) {
             val noBrowserCtaExperiment = extendedOnboardingFeatureToggles.noBrowserCtas().isEnabled()
-            noBrowserCtaExperiment || daxDialogEndShown() || hideTips()
+            noBrowserCtaExperiment || daxDialogEndShown() || hideTips() || !userStageStore.daxOnboardingActive()
         }
     }
 
     suspend fun areInContextDaxDialogsCompleted(): Boolean {
         return withContext(dispatchers.io()) {
             val noBrowserCtaExperiment = extendedOnboardingFeatureToggles.noBrowserCtas().isEnabled()
             val inContextDaxCtasShown = daxDialogSerpShown() && daxDialogTrackersFoundShown() && daxDialogFireEducationShown() && daxDialogEndShown()
-            noBrowserCtaExperiment || inContextDaxCtasShown || hideTips()
+            noBrowserCtaExperiment || inContextDaxCtasShown || hideTips() || !userStageStore.daxOnboardingActive()
         }
     }
 

app/src/test/java/com/duckduckgo/app/cta/ui/OnboardingDaxDialogTests.kt

@@ -177,6 +177,19 @@ class OnboardingDaxDialogTests {
         assertTrue(onboardingComplete)
     }
 
+    @Test
+    fun whenOnboardingCompleteThenAreBubbleDaxDialogsCompletedIsTrue() = runTest {
+        whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.ESTABLISHED)
+        whenever(settingsDataStore.hideTips).thenReturn(false)
+        whenever(dismissedCtaDao.exists(DAX_DIALOG_SERP)).thenReturn(false)
+        whenever(dismissedCtaDao.exists(DAX_DIALOG_TRACKERS_FOUND)).thenReturn(false)
+        whenever(dismissedCtaDao.exists(DAX_FIRE_BUTTON)).thenReturn(false)
+        whenever(dismissedCtaDao.exists(DAX_END)).thenReturn(false)
+
+        val inContextDaxDialogsComplete = testee.areBubbleDaxDialogsCompleted()
+        assertTrue(inContextDaxDialogsComplete)
+    }
+
     @Test
     fun whenAllInContextDialogsShownThenAreInContextDialogsCompletedIsTrue() = runTest {
         whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.DAX_ONBOARDING)
@@ -220,4 +233,17 @@ class OnboardingDaxDialogTests {
         val inContextDaxDialogsComplete = testee.areInContextDaxDialogsCompleted()
         assertTrue(inContextDaxDialogsComplete)
     }
+
+    @Test
+    fun whenOnboardingCompleteThenAreInContextDialogsCompletedIsTrue() = runTest {
+        whenever(userStageStore.getUserAppStage()).thenReturn(AppStage.ESTABLISHED)
+        whenever(settingsDataStore.hideTips).thenReturn(false)
+        whenever(dismissedCtaDao.exists(DAX_DIALOG_SERP)).thenReturn(false)
+        whenever(dismissedCtaDao.exists(DAX_DIALOG_TRACKERS_FOUND)).thenReturn(false)
+        whenever(dismissedCtaDao.exists(DAX_FIRE_BUTTON)).thenReturn(false)
+        whenever(dismissedCtaDao.exists(DAX_END)).thenReturn(false)
+
+        val inContextDaxDialogsComplete = testee.areInContextDaxDialogsCompleted()
+        assertTrue(inContextDaxDialogsComplete)
+    }
 }