Address comments from PR

Author: CrisBarreiro

app/src/main/java/com/duckduckgo/app/browser/BrowserTabViewModel.kt

@@ -3219,7 +3219,7 @@ class BrowserTabViewModel @Inject constructor(
 
         if (!exempted) {
             if (currentBrowserViewState().maliciousSiteDetected && previousSite?.url == url.toString()) return
-            Timber.tag("Cris").d("Received MaliciousSiteWarning for $url, feed: $feed, exempted: false, clientSideHit: $clientSideHit")
+            Timber.d("Received MaliciousSiteWarning for $url, feed: $feed, exempted: false, clientSideHit: $clientSideHit")
             val params = mapOf(CATEGORY_KEY to feed.name.lowercase(), CLIENT_SIDE_HIT_KEY to clientSideHit.toString())
             pixel.fire(AppPixelName.MALICIOUS_SITE_PROTECTION_ERROR_SHOWN, params)
             loadingViewState.postValue(

app/src/main/java/com/duckduckgo/app/browser/webview/MaliciousSiteBlockerWebViewIntegration.kt

@@ -141,8 +141,6 @@ class RealMaliciousSiteBlockerWebViewIntegration @Inject constructor(
             return IsMaliciousViewData.Safe
         }
 
-        Timber.d("shouldIntercept ${request.url}")
-
         val url = request.url.let {
             if (it.fragment != null) {
                 it.buildUpon().fragment(null).build()
@@ -269,7 +267,7 @@ class RealMaliciousSiteBlockerWebViewIntegration @Inject constructor(
             } else {
                 Safe
             }
-            processedUrls[url] = isMalicious
+            processedUrls[url] = it
             confirmationCallback(isMalicious)
         }
     }

app/src/test/java/com/duckduckgo/app/browser/webview/RealMaliciousSiteBlockerWebViewIntegrationTest.kt

@@ -264,6 +264,7 @@ class RealMaliciousSiteBlockerWebViewIntegrationTest {
         val firstCallbackResult = firstCallbackDeferred.await()
         val secondCallbackResult = secondCallbackDeferred.await()
 
+        assertTrue(testee.processedUrls[maliciousUri.toString()] is Malicious)
         assertEquals(false, firstCallbackResult)
         assertEquals(true, secondCallbackResult)
     }

malicious-site-protection/malicious-site-protection-impl/src/main/kotlin/com/duckduckgo/malicioussiteprotection/impl/data/MaliciousSiteRepository.kt

@@ -56,6 +56,8 @@ interface MaliciousSiteRepository {
     suspend fun loadHashPrefixes(): Result<Unit>
 }
 
+private const val MATCHES_ENDPOINT_TIMEOUT = 1000L
+
 @ContributesBinding(AppScope::class)
 @SingleInstanceIn(AppScope::class)
 class RealMaliciousSiteRepository @Inject constructor(
@@ -84,7 +86,7 @@ class RealMaliciousSiteRepository @Inject constructor(
 
     override suspend fun matches(hashPrefix: String): List<Match> {
         return try {
-            withTimeout(1000) {
+            withTimeout(MATCHES_ENDPOINT_TIMEOUT) {
                 maliciousSiteService.getMatches(hashPrefix).matches.mapNotNull {
                     val feed = when (it.feed.uppercase()) {
                         PHISHING.name -> PHISHING