Site Permissions: Code Clean up (#5363)

Task/Issue URL:
https://app.asana.com/0/72649045549333/1208702063802241/f

### Description
This PR finishes cleaning up the code from Site Permissions.
- Moves strings to site permissions module
- Moves Activities to site permissions module
- Removes old LocationPermissions

### Steps to test this PR
Navigate to Site Permissions screen and smoke test it

---------

Co-authored-by: Dax The Translator <[email protected]>

Author: malmstein

app/src/androidTest/java/com/duckduckgo/app/browser/BrowserTabViewModelTest.kt

@@ -142,7 +142,6 @@ import com.duckduckgo.app.global.install.AppInstallStore
 import com.duckduckgo.app.global.model.PrivacyShield.PROTECTED
 import com.duckduckgo.app.global.model.Site
 import com.duckduckgo.app.global.model.SiteFactoryImpl
-import com.duckduckgo.app.location.GeoLocationPermissions
 import com.duckduckgo.app.location.data.LocationPermissionsDao
 import com.duckduckgo.app.onboarding.store.AppStage
 import com.duckduckgo.app.onboarding.store.AppStage.ESTABLISHED
@@ -370,8 +369,6 @@ class BrowserTabViewModelTest {
 
     private val mockFileDownloader: FileDownloader = mock()
 
-    private val geoLocationPermissions: GeoLocationPermissions = mock()
-
     private val fireproofDialogsEventHandler: FireproofDialogsEventHandler = mock()
 
     private val mockEmailManager: EmailManager = mock()
@@ -3038,8 +3035,6 @@ class BrowserTabViewModelTest {
         )
 
         givenCurrentSite(domain)
-        givenDeviceLocationSharingIsEnabled(true)
-        givenLocationPermissionIsEnabled(true)
 
         loadUrl("https://www.example.com", isBrowserShowing = true)
 
@@ -3055,8 +3050,6 @@ class BrowserTabViewModelTest {
         )
 
         givenCurrentSite(domain)
-        givenDeviceLocationSharingIsEnabled(true)
-        givenLocationPermissionIsEnabled(true)
 
         loadUrl("https://www.example.com", isBrowserShowing = true)
 
@@ -3066,8 +3059,6 @@ class BrowserTabViewModelTest {
     @Test
     fun whenUserVisitsDomainWithoutLocationPermissionThenMessageIsNotShown() = runTest {
         val domain = "https://www.example.com"
-        givenDeviceLocationSharingIsEnabled(true)
-        givenLocationPermissionIsEnabled(true)
         givenCurrentSite(domain)
         loadUrl("https://www.example.com", isBrowserShowing = true)
 
@@ -3077,8 +3068,6 @@ class BrowserTabViewModelTest {
     @Test
     fun whenUserVisitsDomainAndLocationIsNotEnabledThenMessageIsNotShown() = runTest {
         val domain = "https://www.example.com"
-        givenDeviceLocationSharingIsEnabled(true)
-        givenLocationPermissionIsEnabled(false)
         givenCurrentSite(domain)
 
         loadUrl("https://www.example.com", isBrowserShowing = true)
@@ -3095,8 +3084,6 @@ class BrowserTabViewModelTest {
         )
 
         givenCurrentSite(domain)
-        givenDeviceLocationSharingIsEnabled(true)
-        givenLocationPermissionIsEnabled(true)
 
         loadUrl("https://www.example.com", isBrowserShowing = true)
         loadUrl("https://www.example.com", isBrowserShowing = true)
@@ -5901,14 +5888,6 @@ class BrowserTabViewModelTest {
         dismissedCtaDaoChannel.send(listOf(DismissedCta(CtaId.DAX_DIALOG_TRACKERS_FOUND)))
     }
 
-    private fun givenDeviceLocationSharingIsEnabled(state: Boolean) {
-        whenever(geoLocationPermissions.isDeviceLocationEnabled()).thenReturn(state)
-    }
-
-    private fun givenLocationPermissionIsEnabled(state: Boolean) {
-        whenever(mockSettingsStore.appLocationPermission).thenReturn(state)
-    }
-
     private inline fun <reified T : Command> assertCommandIssued(instanceAssertions: T.() -> Unit = {}) {
         verify(mockCommandObserver, atLeastOnce()).onChanged(commandCaptor.capture())
         val issuedCommand = commandCaptor.allValues.find { it is T }

app/src/androidTest/java/com/duckduckgo/app/browser/favicon/DuckDuckGoFaviconManagerTest.kt

@@ -29,7 +29,6 @@ import com.duckduckgo.app.browser.favicon.FileBasedFaviconPersister.Companion.NO
 import com.duckduckgo.app.fire.fireproofwebsite.data.FireproofWebsiteDao
 import com.duckduckgo.app.fire.fireproofwebsite.data.FireproofWebsiteRepositoryImpl
 import com.duckduckgo.app.location.data.LocationPermissionsDao
-import com.duckduckgo.app.location.data.LocationPermissionsRepositoryImpl
 import com.duckduckgo.autofill.api.store.AutofillStore
 import com.duckduckgo.common.test.CoroutineTestRule
 import com.duckduckgo.common.utils.faviconLocation
@@ -75,11 +74,6 @@ class DuckDuckGoFaviconManagerTest {
             faviconPersister = mockFaviconPersister,
             savedSitesDao = mockSavedSitesDao,
             fireproofWebsiteRepository = FireproofWebsiteRepositoryImpl(mockFireproofWebsiteDao, coroutineRule.testDispatcherProvider, mock()),
-            locationPermissionsRepository = LocationPermissionsRepositoryImpl(
-                mockLocationPermissionsDao,
-                mock(),
-                coroutineRule.testDispatcherProvider,
-            ),
             savedSitesRepository = mockSavedSitesRepository,
             faviconDownloader = mockFaviconDownloader,
             dispatcherProvider = coroutineRule.testDispatcherProvider,

app/src/androidTest/java/com/duckduckgo/app/global/view/ClearPersonalDataActionTest.kt

@@ -26,7 +26,6 @@ import com.duckduckgo.app.fire.AppCacheClearer
 import com.duckduckgo.app.fire.UnsentForgetAllPixelStore
 import com.duckduckgo.app.fire.fireproofwebsite.data.FireproofWebsiteEntity
 import com.duckduckgo.app.fire.fireproofwebsite.data.FireproofWebsiteRepository
-import com.duckduckgo.app.location.GeoLocationPermissions
 import com.duckduckgo.app.settings.db.SettingsDataStore
 import com.duckduckgo.app.tabs.model.TabRepository
 import com.duckduckgo.cookies.api.DuckDuckGoCookieManager
@@ -56,7 +55,6 @@ class ClearPersonalDataActionTest {
     private val mockSettingsDataStore: SettingsDataStore = mock()
     private val mockCookieManager: DuckDuckGoCookieManager = mock()
     private val mockAppCacheClearer: AppCacheClearer = mock()
-    private val mockGeoLocationPermissions: GeoLocationPermissions = mock()
     private val mockThirdPartyCookieManager: ThirdPartyCookieManager = mock()
     private val mockAdClickManager: AdClickManager = mock()
     private val mockFireproofWebsiteRepository: FireproofWebsiteRepository = mock()
@@ -78,7 +76,6 @@ class ClearPersonalDataActionTest {
             settingsDataStore = mockSettingsDataStore,
             cookieManager = mockCookieManager,
             appCacheClearer = mockAppCacheClearer,
-            geoLocationPermissions = mockGeoLocationPermissions,
             thirdPartyCookieManager = mockThirdPartyCookieManager,
             adClickManager = mockAdClickManager,
             fireproofWebsiteRepository = mockFireproofWebsiteRepository,
@@ -131,7 +128,7 @@ class ClearPersonalDataActionTest {
     @Test
     fun whenClearCalledThenGeoLocationPermissionsAreCleared() = runTest {
         testee.clearTabsAndAllDataAsync(appInForeground = false, shouldFireDataClearPixel = false)
-        verify(mockGeoLocationPermissions).clearAllButFireproofed()
+        verify(mockSitePermissionsManager).clearAllButFireproof(any())
     }
 
     @Test

app/src/androidTest/java/com/duckduckgo/app/location/GeoLocationPermissionsTest.kt

@@ -376,15 +376,6 @@
             android:exported="false"
             android:label="@string/fireproofWebsitesActivityTitle"
             android:parentActivityName="com.duckduckgo.app.settings.SettingsActivity" />
-        <activity
-            android:name="com.duckduckgo.app.sitepermissions.SitePermissionsActivity"
-            android:exported="false"
-            android:label="@string/settingsSitePermissions"
-            android:parentActivityName="com.duckduckgo.app.settings.SettingsActivity" />
-        <activity
-            android:name="com.duckduckgo.app.sitepermissions.permissionsperwebsite.PermissionsPerWebsiteActivity"
-            android:exported="false"
-            android:parentActivityName="com.duckduckgo.app.sitepermissions.SitePermissionsActivity" />
         <activity
             android:name="com.duckduckgo.app.fire.FireActivity"
             android:exported="false"

app/src/main/AndroidManifest.xml

@@ -205,7 +205,7 @@ class AppearanceActivity : DuckDuckGoActivity() {
                 ),
                 OmnibarPosition.entries.indexOf(position) + 1,
             )
-            .setPositiveButton(R.string.dialogSave)
+            .setPositiveButton(com.duckduckgo.mobile.android.R.string.dialogSave)
             .setNegativeButton(R.string.cancel)
             .addEventListener(
                 object : RadioListAlertDialogBuilder.EventListener() {

app/src/main/java/com/duckduckgo/app/appearance/AppearanceActivity.kt

@@ -60,7 +60,6 @@ import com.duckduckgo.app.pixels.AppPixelName
 import com.duckduckgo.app.pixels.AppPixelName.FIRE_DIALOG_CANCEL
 import com.duckduckgo.app.settings.SettingsActivity
 import com.duckduckgo.app.settings.db.SettingsDataStore
-import com.duckduckgo.app.sitepermissions.SitePermissionsActivity
 import com.duckduckgo.app.statistics.pixels.Pixel
 import com.duckduckgo.app.tabs.model.TabEntity
 import com.duckduckgo.appbuildconfig.api.AppBuildConfig
@@ -79,6 +78,7 @@ import com.duckduckgo.privacy.dashboard.api.ui.DashboardOpener
 import com.duckduckgo.privacy.dashboard.api.ui.PrivacyDashboardHybridScreenParams.PrivacyDashboardPrimaryScreen
 import com.duckduckgo.privacy.dashboard.api.ui.PrivacyDashboardHybridScreenParams.PrivacyDashboardToggleReportScreen
 import com.duckduckgo.savedsites.impl.bookmarks.BookmarksActivity.Companion.SAVED_SITE_URL_EXTRA
+import com.duckduckgo.site.permissions.impl.ui.SitePermissionScreenNoParams
 import javax.inject.Inject
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Job
@@ -535,7 +535,7 @@ open class BrowserActivity : DuckDuckGoActivity() {
     }
 
     fun launchSitePermissionsSettings() {
-        startActivity(SitePermissionsActivity.intent(this))
+        globalActivityStarter.start(this, SitePermissionScreenNoParams)
     }
 
     fun launchBookmarks() {

app/src/main/java/com/duckduckgo/app/browser/BrowserActivity.kt

@@ -28,7 +28,6 @@ import com.duckduckgo.app.browser.favicon.FileBasedFaviconPersister.Companion.NO
 import com.duckduckgo.app.fire.fireproofwebsite.data.FireproofWebsiteRepository
 import com.duckduckgo.app.global.view.generateDefaultDrawable
 import com.duckduckgo.app.global.view.loadFavicon
-import com.duckduckgo.app.location.data.LocationPermissionsRepository
 import com.duckduckgo.autofill.api.store.AutofillStore
 import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.common.utils.baseHost
@@ -44,7 +43,6 @@ class DuckDuckGoFaviconManager constructor(
     private val faviconPersister: FaviconPersister,
     private val savedSitesDao: SavedSitesEntitiesDao,
     private val fireproofWebsiteRepository: FireproofWebsiteRepository,
-    private val locationPermissionsRepository: LocationPermissionsRepository,
     private val savedSitesRepository: SavedSitesRepository,
     private val faviconDownloader: FaviconDownloader,
     private val dispatcherProvider: DispatcherProvider,
@@ -269,7 +267,6 @@ class DuckDuckGoFaviconManager constructor(
 
         return withContext(dispatcherProvider.io()) {
             savedSitesDao.countEntitiesByUrl(query) +
-                locationPermissionsRepository.permissionEntitiesCountByDomain(query) +
                 fireproofWebsiteRepository.fireproofWebsitesCountByDomain(domain) +
                 savedSitesRepository.getFavoritesCountByDomain(query) +
                 autofillStore.getCredentials(domain).size

app/src/main/java/com/duckduckgo/app/browser/favicon/DuckDuckGoFaviconManager.kt

@@ -18,7 +18,6 @@ package com.duckduckgo.app.browser.favicon
 
 import android.content.Context
 import com.duckduckgo.app.fire.fireproofwebsite.data.FireproofWebsiteRepository
-import com.duckduckgo.app.location.data.LocationPermissionsRepository
 import com.duckduckgo.autofill.api.store.AutofillStore
 import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.di.scopes.AppScope
@@ -38,7 +37,6 @@ class FaviconModule {
         faviconPersister: FaviconPersister,
         bookmarksDao: SavedSitesEntitiesDao,
         fireproofWebsiteRepository: FireproofWebsiteRepository,
-        locationPermissionsRepository: LocationPermissionsRepository,
         savedSitesRepository: SavedSitesRepository,
         faviconDownloader: FaviconDownloader,
         dispatcherProvider: DispatcherProvider,
@@ -50,7 +48,6 @@ class FaviconModule {
             faviconPersister,
             bookmarksDao,
             fireproofWebsiteRepository,
-            locationPermissionsRepository,
             savedSitesRepository,
             faviconDownloader,
             dispatcherProvider,