Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update docs + test with Node.js v20 #85

Closed
3 tasks done
nelsonic opened this issue Jan 17, 2024 · 3 comments
Closed
3 tasks done

Chore: Update docs + test with Node.js v20 #85

nelsonic opened this issue Jan 17, 2024 · 3 comments
Assignees
@nelsonic
Labels
chore enhancement T1h technical

Comments

@nelsonic
Copy link
Member

nelsonic commented Jan 17, 2024 •
edited
Loading

Text in the repo refers to Node.js v.12 which has been deprecated for a while ...
https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
image

Todo

  • Update to v20
  • Update all docs
  • Test deployment with sample lambda function

Note: this is not related to the MVP or any other P1 issue.
But I want to get this done: dwyl/who#86
@nelsonic nelsonic self-assigned this Jan 19, 2024
nelsonic added a commit that referenced this issue Jan 19, 2024
@nelsonic
add .github dir run CI on GitHub Actions #85
a37ca69
nelsonic added a commit that referenced this issue Jan 19, 2024
@nelsonic
update runtime in upload.js to "Runtime: nodejs20.x" #85
12aa41f
@nelsonic
Copy link
Member Author

As per the old Travis CI file:

aws-lambda-deploy/.travis.yml

Lines 7 to 12 in b3ace4a

before_install:
- mkdir tmp
- chmod 777 tmp
# create a dummy .env file on CI:
- echo "export HELLO=world" >> .env
- cat .env

We need to perform a couple of setup tasks before running the tests on GitHub CI ...
Reading: https://github.com/orgs/community/discussions/27136

nelsonic added a commit that referenced this issue Jan 20, 2024
@nelsonic
attempt to add pre flight checks to ci.yml ref: #85 (comment)
47c048f
@nelsonic nelsonic mentioned this issue Jan 22, 2024
Closed
3 tasks
nelsonic added a commit that referenced this issue Jan 23, 2024
@nelsonic
update comment link from #65 to #85
1eb19de
nelsonic added a commit that referenced this issue Jan 23, 2024
@nelsonic
update build badge and comment out "npm run lint" #85
48af64b
asntc added a commit that referenced this issue Jan 23, 2024
@asntc
Merge pull request #86 from dwyl/update-to-node-v20-issue-#85
8de1fd5 
PR: Update to `Node v20` issue #85
nelsonic added a commit that referenced this issue Jan 23, 2024
@nelsonic
use full path to /home/runner/work/aws-lambda-deploy/aws-lambda-deplo…
bc7e678 
…y/.env in ci.yml #85
nelsonic added a commit that referenced this issue Jan 23, 2024
@nelsonic
remove -r from mkdir command in ci.yml #85
89daf81
nelsonic added a commit that referenced this issue Jan 23, 2024
@nelsonic
remove dependency badges (not working...) #85
e252c6d
nelsonic added a commit that referenced this issue Jan 23, 2024
@nelsonic
echo $TMPDIR #85
1c29aa1
nelsonic added a commit that referenced this issue Jan 23, 2024
@nelsonic
echo "$TMPDIR" #85
283a087
nelsonic added a commit that referenced this issue Jan 23, 2024
@nelsonic
attemp to debug process.env.TMPDIR #85
2c3a68b
nelsonic added a commit that referenced this issue Jan 24, 2024
@nelsonic
attempt to hard-code TMPDIR in ci.yml #85
58ef726
nelsonic added a commit that referenced this issue Jan 24, 2024
@nelsonic
directly reference all environment variables in ci.yml #85
937b1ff
nelsonic added a commit that referenced this issue Jan 24, 2024
@nelsonic
downgrade engine from 20.x to 18.x in package.json #85
25c4136
nelsonic added a commit that referenced this issue Jan 24, 2024
@nelsonic
add trailing forwardslash to TMPDIR in ci.yml #85
2ceaf10
nelsonic added a commit that referenced this issue Jan 24, 2024
@nelsonic
use ${{ runner.tmp }} for TMPDIR ref: https://docs.github.com/en/acti…
16fab72 
…ons/learn-github-actions/contexts#runner-context #85
nelsonic added a commit that referenced this issue Jan 24, 2024
@nelsonic
trailing slash ... 🙄 #85
ca5eb8c
nelsonic added a commit that referenced this issue Jan 24, 2024
@nelsonic
attempt to mkdir /home/runner/work/_temp/my_dir #85
126adaa
nelsonic added a commit that referenced this issue Jan 24, 2024
@nelsonic
mkdir /home/runner/work/_temp/unzipped #85
9d08633
nelsonic added a commit that referenced this issue Jan 25, 2024
@nelsonic
debug fakedir error #92 (comment) for #85
141c18d
nelsonic added a commit that referenced this issue Jan 25, 2024
@nelsonic
mkdir /home/runner/work/_temp/fakedir #92 (comment) #85
042bbd7
nelsonic added a commit that referenced this issue Jan 26, 2024
@nelsonic
npm WARN config production Use --omit=dev instead. #85
973670d
nelsonic added a commit that referenced this issue Jan 26, 2024
@nelsonic
mkdir /home/runner/work/_temp/dist #85
8cd2df9
nelsonic added a commit that referenced this issue Feb 3, 2024
@nelsonic
temporarily comment-out second call to upload in test/05_upload.test.…
fc42ef4 
…js as throwing unrecoverable error for no reason ... #85
nelsonic added a commit that referenced this issue Feb 3, 2024
@nelsonic
only test on one version of node.js until update complete #85
2a1e055
nelsonic added a commit that referenced this issue Feb 3, 2024
@nelsonic
delete function in test/000_debug.test.js before running tests on Git…
e3c1f26 
…Hub CI #85
nelsonic added a commit that referenced this issue Feb 3, 2024
@nelsonic
delete .travis.yml as no longer working ref: dwyl/learn-travis#67 #85
5ba173e
nelsonic added a commit that referenced this issue Feb 3, 2024
@nelsonic
ignore updateFunction as not tested because SDK is throwing an uncatc…
bfc3a4f 
…hable error ... #85
nelsonic added a commit that referenced this issue Feb 3, 2024
@nelsonic
re-enable testing on various versions of Node.js #85
d7c7b23
nelsonic added a commit that referenced this issue Feb 3, 2024
@nelsonic
only test on node.js v20 (LTS) #85
875c506
@nelsonic nelsonic mentioned this issue Feb 3, 2024
Closed
nelsonic added a commit that referenced this issue Feb 3, 2024
@nelsonic
update README.md #85
8b1ed15
nelsonic added a commit that referenced this issue Feb 3, 2024
@nelsonic
Upgrade from aws-sdk (v2) to @aws-sdk/client-lambda (v3) #85
e84d079
nelsonic added a commit that referenced this issue Feb 4, 2024
@nelsonic
secrets.AWS_IAM_ROLE #85
d39ae23
nelsonic added a commit that referenced this issue Feb 4, 2024
@nelsonic
Update to AWS SDK v3! #85
78fd4a8
asntc added a commit that referenced this issue Feb 4, 2024
@asntc
Merge pull request #92 from dwyl/update-to-node-v20-issue-#85
a2e1572 
PR: Update to `Node.js v20` #85
@nelsonic
Copy link
Member Author

Closing as done. This is working well. ✅

@nelsonic
Copy link
Member Author

Next: #108 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
chore enhancement T1h technical
Projects
Nelson's List
Status: Done
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic