Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Updates will appear here when WebSockets are working ..." Text #149

Closed
1 task done
nelsonic opened this issue Mar 8, 2022 · 3 comments
Closed
1 task done

Remove "Updates will appear here when WebSockets are working ..." Text #149

nelsonic opened this issue Mar 8, 2022 · 3 comments
Assignees
@SimonLab
Labels
awaiting-review chore priority-3 T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.

Comments

@nelsonic
Copy link
Member

nelsonic commented Mar 8, 2022 •
edited
Loading

Simon fixed the WebSockets issue #129 so the updates are showing on https://hits.dwyl.com

Screen Shot 2022-03-08 at 10 23 01

But the text is still there: "Updates will appear here when WebSockets are working ..."

Todo

  • Replace the text with the updates when WebSockets are working.
@nelsonic nelsonic added priority-3 chore T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule. labels Mar 8, 2022
@SimonLab SimonLab mentioned this issue Mar 8, 2022
Merged
@SimonLab SimonLab self-assigned this Mar 8, 2022
@SimonLab
Copy link
Member

SimonLab commented Mar 8, 2022

This should be fixed with #151
I've added an id to the div which display the default text and when new socket messages arrive I check if the div exist and remove it.

@nelsonic
Copy link
Member Author

nelsonic commented Mar 8, 2022

Thanks for removing this @SimonLab

@nelsonic
Copy link
Member Author

nelsonic commented Mar 8, 2022

Fixed:

image

@nelsonic nelsonic closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimonLab SimonLab

Labels
awaiting-review chore priority-3 T5m Quick tasks that take 5 mins or less. See: GTD 2 min rule.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nelsonic @SimonLab