Feat: items_with_timers/1
-> items_with_timers/2
(list_cid
)
#423
Labels
chore
a tedious but necessary task often paying technical debt
elixir
Pull requests that update Elixir code
enhancement
New feature or enhancement of existing functionality
priority-2
Second highest priority, should be worked on as soon as the Priority-1 issues are finished
T1h
Time Estimate 1 Hour
technical
A technical issue that requires understanding of the code, infrastructure or dependencies
At present the route for the
/lists
on the #165 PR is currently:mvp/lib/app_web/router.ex
Line 32 in 10a2a6a
i.e: there is no "page" to
:show
thelist
.There is no function in the
controller
for displaying thelist
.However we planned ahead for this when introducing
lists
...The
items_with_timers/1
function currentlyhttps://github.com/dwyl/mvp/blob/b8aee0e3c29d0cb45025595131248c08fbbf6a31/lib/app/item.ex#L216C7-L218
We need to update the function to accept a
list_cid
as the second parameter.and lookup the
list
usingget_list_by_cid!/1
Then we can filter the
items
based on thelist.seq
.Todo
list_cid
argument toitems_with_timers/1
to make ititems_with_timers/2
list_cid
isnil
then default to the "all"list
.items_with_timers/2
test with a differentlist_cid
.The text was updated successfully, but these errors were encountered: