Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is/== issue in width.py #80

Open
davethomas074 opened this issue Nov 7, 2023 · 1 comment
Open

is/== issue in width.py #80

davethomas074 opened this issue Nov 7, 2023 · 1 comment

Comments

@davethomas074
Copy link

Small thing here - My linter is complaining about the code here and here, because we should really be using == for string comparison, not is, right?

if bintype == "log": vs if bintype is "log"

I looked through the issues and didn't see anyone else bringing this up. I'm happy to submit a PR but I wanted to bring it up here, before I just went ahead and did that.

Please let me know if a quick PR for this would be welcomed!

@davethomas074 davethomas074 changed the title is/= issue in width.py is/== issue in width.py Nov 7, 2023
@e-koch
Copy link
Owner

e-koch commented Nov 9, 2023

A PR would be appreciated! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants