Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: migrate from globby to tinyglobby #4096

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: migrate from globby to tinyglobby #4096

wants to merge 1 commit into from

Conversation

mcmxcdev
Copy link
Contributor

Description

  • uninstall globby dependency
  • install tinyglobby dependency
  • replace usages of globby with tinyglobby in various files

Motivation and Context

Closes e18e/ecosystem-issues#102

npmgraph.js.org?q=globby uses a total of 23 dependencies, while npmgraph.js.org?q=tinyglobby only uses 2.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcmxcdev mcmxcdev marked this pull request as ready for review October 16, 2024 20:48
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 31, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit a49c298.

Command Status Duration Result
nx run-many -t lint --parallel=3 ✅ Succeeded 6s View ↗
nx-cloud record -- npx nx format:check ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-19 14:51:19 UTC

@JamesHenry JamesHenry changed the title chore: migrate from globby to tinyglobby fix: migrate from globby to tinyglobby Oct 31, 2024
@JamesHenry
Copy link
Member

Per my other comment on the other PR, I have marked this as a fix

benmccann
benmccann reviewed Dec 14, 2024
View reviewed changes
packages/legacy-package-management/package.json
@@ -88,6 +87,7 @@
"tar": "6.2.1",
"temp-dir": "1.0.0",
"tempy": "1.0.0",
"tinyglobby": "0.2.9",
Copy link

@benmccann benmccann Dec 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend upgrading to 0.2.12 here and in the other package.json files

Suggested change
"tinyglobby": "0.2.9",
"tinyglobby": "0.2.12",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally, I would wait for a review/approval first though.

@benmccann
Copy link

@JamesHenry what do you think about this PR? It matches the same change already made in nx

@mcmxcdev @JamesHenry
chore: migrate from globby to tinyglobby
a49c298 
- uninstall globby dependency
- install tinyglobby dependency
- replace usages of globby with tinyglobby in various files
@JamesHenry JamesHenry force-pushed the chore/migrate-from-globby-to-tinyglobby branch from e760370 to a49c298 Compare February 19, 2025 14:47
@benmccann
Copy link

@JamesHenry I see you did a force push on this PR last week. It looks like the CI is failing now. I'm not sure what changed and can't tell from the logs what's wrong. It looks like maybe a lint error? Could you provide any insight? If you have time, it'd be awesome if you might be able to push a quick fix for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate lerna to tinyglobby
3 participants
@mcmxcdev @JamesHenry @benmccann