-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigation: is-number #17
Comments
I took a random stab at this today and replaced |
ultimately i wonder if we could have a even if we still have |
another |
great find 🙏 IMO we should migrate towards |
I'm helping out with some ecosystem cleanup and this dependency came up as a possible contender. Reference: e18e/ecosystem-issues#17. I don't have a strong opinion here, but happy to discuss. https://npmgraph.js.org/?q=braces https://npmgraph.js.org/?q=brace-expansion
to-regex-range no longer depends on is-number but is still not published on npm |
once that and chokidar 4 are published, we should do a follow up investigation into what's left depending on is-number I suspect it won't be many packages anymore if it is a very low impact amount, we can probably close this issue at that point |
Just notes for how we can tackle this one.
Of course,
typeof obj === 'number'
will be fine for most consumersthere may be edge cases where this package is necessary, but most likely it belongs in edge cases rather than the common case.
Significant dependents
slice(start, -1)
slice(-offset)
Highest impact chain
to-regex-range
is the key here. The primary path is:braces
fill-range
to-regex-range
is-number
The first primary package we reach is
braces
, a package for bash-like brace expansion.We can probably replace
braces
with brace-expansion.Some significant consumers of
braces
are:If we move these to use
brace-expansion
(or any other light alternative we can agree on), we will likely strip is-number from most of the common dependency trees.The text was updated successfully, but these errors were encountered: