Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce standard-changelog dependency count #67

Open
SuperchupuDev opened this issue Jul 3, 2024 · 10 comments
Open

Reduce standard-changelog dependency count #67

SuperchupuDev opened this issue Jul 3, 2024 · 10 comments
Labels
accepts prs The maintainer of the target repo was contacted and welcomes prs has issue An issue for contact or tracking was created in the target repository

Comments

@SuperchupuDev
Copy link

SuperchupuDev commented Jul 3, 2024

51 dependencies, many of which seem to come from read-package-up. they don't seem to look at prs much though, one i submitted two months ago moving @types/semver to devDeps never got any reviews or comments (conventional-changelog/conventional-changelog#1268)

https://npmgraph.js.org/[email protected]

@SuperchupuDev
Copy link
Author

@43081j
Copy link
Collaborator

43081j commented Jul 6, 2024

fyi there's also fd-package-json we released some time ago to fill this gap. a few libs already moved to it

pkg-types is pretty chunky thanks to the confbox parsers it comes with (yaml parser etc). if you don't need something specific out of pkg-types, i'd probably just use fd-package-json

@SuperchupuDev
Copy link
Author

looks smaller, will try to use :)

@SuperchupuDev
Copy link
Author

done, thank you! four less subdependencies

@SuperchupuDev
Copy link
Author

@armano2
Copy link

armano2 commented Aug 18, 2024

This repo usually takes bunch of time to actually release package changes, tho over quiet some time I managed to push bunch of code reduction, and nativisation changes out

This most likely is going to take some time for changes to be merged

Ref conventional-changelog/conventional-changelog#753

@43081j
Copy link
Collaborator

43081j commented Aug 19, 2024

great work 🎉

even if it takes some time, this'll be a good improvement. let us know if you need any help over there

@Fuzzyma Fuzzyma added needs first contact It is unclear if the maintainer of the repo is open for e18e has issue An issue for contact or tracking was created in the target repository has pr This issue has a corresponding PR in the target repo labels Dec 18, 2024
@SuperchupuDev
Copy link
Author

my two prs got merged 🎉

@Fuzzyma
Copy link
Collaborator

Fuzzyma commented Jan 7, 2025

@SuperchupuDev nice! Does that mean we are done with standard-changelog and can close this issue? :)

@SuperchupuDev
Copy link
Author

while my two prs got merged, i believe there are further potential improvements that can be done, so i'd leave this open :-)

@Fuzzyma Fuzzyma added accepts prs The maintainer of the target repo was contacted and welcomes prs and removed needs first contact It is unclear if the maintainer of the repo is open for e18e has pr This issue has a corresponding PR in the target repo labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepts prs The maintainer of the target repo was contacted and welcomes prs has issue An issue for contact or tracking was created in the target repository
Projects
None yet
Development

No branches or pull requests

4 participants