Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme #4

Closed
wants to merge 1 commit into from
Closed

Conversation

karlosmatos
Copy link

Adding mode toggle with updated UI colors to support dark theme.

@mlejva
Copy link
Member

mlejva commented Jul 27, 2024

Hey @karlosmatos thank you for the PR. I checked it and there's a few more details that would need to get fixed before we can merge this PR:

Screenshot 2024-07-27 at 2 10 17 PM
The left up and bottom corners aren't rounded and it looks bad on the dark theme.

Screenshot 2024-07-27 at 2 11 11 PM
The code's text output isn't visible.

Screenshot 2024-07-27 at 2 11 48 PM
Borders of the selected input should be highlighted with some dark-friendly color

Screenshot 2024-07-27 at 2 13 34 PM
We could pick a better code's color theme for the dark theme.

@mlejva
Copy link
Member

mlejva commented Nov 6, 2024

We built a dark mode in the meantime

@mlejva mlejva closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants