[21657] cannot build request_reply example #5231

allbluelai · 2024-09-12T12:50:41Z

allbluelai
Sep 12, 2024

Is there an already existing issue for this?

I have searched the existing issues

Expected behavior

Compile the request_reply example correctly.

Current behavior

Cannot build request_reply example.

Steps to reproduce

Download fastdds.repos:

vcs import --input fastdds.repos .

My workspace is as follows:

$ tree -L 1
.
├── build.sh
├── fastcdr
├── fastdds
├── fastddsgen
├── fastdds.repos
├── foonathan_memory_vendor
├── install
└── request_reply

6 directories, 2 files

Build all libraries and install them. Here, I use the following script:

#!/bin/bash

clear

set -e

current_path=$(pwd)

mkdir -p ${current_path}/foonathan_memory_vendor/build
cd ${current_path}/foonathan_memory_vendor/build
cmake .. -DCMAKE_INSTALL_PREFIX=${current_path}/install
make install


mkdir -p ${current_path}/fastcdr/build
cd ${current_path}/fastcdr/build
cmake .. -DCMAKE_INSTALL_PREFIX=${current_path}/install
make install


mkdir -p ${current_path}/fastdds/build
cd ${current_path}/fastdds/build
cmake .. -DCMAKE_INSTALL_PREFIX=${current_path}/install -DCMAKE_PREFIX_PATH=${current_path}/install
make install


mkdir -p ${current_path}/request_reply/build
cd ${current_path}/request_reply/build
cmake .. -DCMAKE_INSTALL_PREFIX=${current_path}/install -DCMAKE_PREFIX_PATH=${current_path}/install
make

When build the request_reply example, it outputs:

-- The CXX compiler identification is GNU 11.4.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "3.0.2")  
-- Performing Test SUPPORTS_CXX11
-- Performing Test SUPPORTS_CXX11 - Success
-- Configuring fastdds_request_reply_example...
-- Configuring done
-- Generating done
-- Build files have been written to: /home/john/Documents/fast1/request_reply/build
[ 12%] Building CXX object CMakeFiles/request_reply.dir/types/CalculatorPubSubTypes.cxx.o
[ 25%] Building CXX object CMakeFiles/request_reply.dir/types/CalculatorTypeObjectSupport.cxx.o
[ 37%] Building CXX object CMakeFiles/request_reply.dir/Application.cpp.o
[ 50%] Building CXX object CMakeFiles/request_reply.dir/ClientApp.cpp.o
[ 62%] Building CXX object CMakeFiles/request_reply.dir/ServerApp.cpp.o
[ 75%] Building CXX object CMakeFiles/request_reply.dir/CMakeFiles/3.22.1/CompilerIdCXX/CMakeCXXCompilerId.cpp.o
[ 87%] Building CXX object CMakeFiles/request_reply.dir/main.cpp.o
[100%] Linking CXX executable request_reply
/usr/bin/ld: CMakeFiles/request_reply.dir/main.cpp.o: in function `main':
main.cpp:(.text+0x20c): multiple definition of `main'; CMakeFiles/request_reply.dir/CMakeFiles/3.22.1/CompilerIdCXX/CMakeCXXCompilerId.cpp.o:CMakeCXXCompilerId.cpp:(.text+0x0): first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/request_reply.dir/build.make:200: request_reply] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/request_reply.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Fast DDS version/commit

v3.3.0

Platform/Architecture

Other. Please specify in Additional context section.

Transport layer

Default configuration, UDPv4 & SHM

Additional context

$ uname -a
Linux john 6.5.0-45-generic #45~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Mon Jul 15 16:40:02 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

XML configuration file

No response

Relevant log output

No response

Network traffic capture

No response

JesusPoderoso · 2024-09-12T13:46:18Z

JesusPoderoso
Sep 12, 2024
Collaborator

Hi @allbluelai, thanks for using Fast DDS.

It seems that the compilation autogenerated file CMakeCXXCompilerId.cpp contains also a main method.
This issue can be avoided by building the example in a different directory.
It can be easily done by building all the examples when building fastdds (with the cmake flag COMPILE_EXAMPLES as ON)

mkdir -p ${current_path}/fastdds/build
cd ${current_path}/fastdds/build
cmake .. -DCMAKE_INSTALL_PREFIX=${current_path}/install -DCMAKE_PREFIX_PATH=${current_path}/install -DCOMPILE_EXAMPLES=ON
make install

I am moving this ticket to the support section according to the Fast DDS CONTRIBUTING guidelines.

6 replies

JesusPoderoso Sep 13, 2024
Collaborator

Further investigation has revealed an error in the CMakeList.txt.
We will review the remain examples and open a PR to fix all of them, but here is the fix so you can already build the example:

In this example, the generated types are located in a types subfolder, so they are included in the build process using file(GLOB_RECURSIVE ..., which is introducing also CMake files generated in build time.
This can be avoided applying this git diff in the CMakeLists.txt file.

diff --git a/examples/cpp/request_reply/CMakeLists.txt b/examples/cpp/request_reply/CMakeLists.txt
index 868bea971..e12fadb2e 100644
--- a/examples/cpp/request_reply/CMakeLists.txt
+++ b/examples/cpp/request_reply/CMakeLists.txt
@@ -35,10 +35,12 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
 endif()
 
 message(STATUS "Configuring ${PROJECT_NAME}...")
-file(GLOB_RECURSE REQUEST_REPLY_SOURCES_CXX "*.cxx")
-file(GLOB_RECURSE REQUEST_REPLY_SOURCES_CPP "*.cpp")
+file(GLOB REQUEST_REPLY_TYPES_SOURCES_CXX "types/*.cxx")
+file(GLOB REQUEST_REPLY_SOURCES_CXX "*.cxx")
+file(GLOB REQUEST_REPLY_TYPES_SOURCES_CPP "types/*.cpp")
+file(GLOB REQUEST_REPLY_SOURCES_CPP "*.cpp")
 
-add_executable(request_reply ${REQUEST_REPLY_SOURCES_CXX} ${REQUEST_REPLY_SOURCES_CPP})
+add_executable(request_reply ${REQUEST_REPLY_SOURCES_CXX} ${REQUEST_REPLY_SOURCES_CPP} ${REQUEST_REPLY_TYPES_SOURCES_CXX} ${REQUEST_REPLY_TYPES_SOURCES_CPP})

JesusPoderoso Sep 13, 2024
Collaborator

@allbluelai FYI: the fix has been applied in this PR:

[21663] Fix request reply example isolated build #5236

allbluelai Sep 13, 2024
Author

@allbluelai FYI: the fix has been applied in this PR:

[21663] Fix request reply example isolated build #5236

@JesusPoderoso Thanks a lot. The new CMakeLists.txt works fine.
But a new problem occurred when running the client:

$ ./request_reply client 2 x 5
2024-09-13 18:58:13.967 [CLI_PARSER Error] Incorrect number of arguments for client entity -> Function parse_cli_options
Service to perform several operations (addition, 
subtraction, multiplication, and division) on two 16-bit
integers

Usage: request_reply <entity> [options] [arguments]

Example:
  - request_reply server
  - request_reply client 4 5

Entities:
  server                        Run a server entity
  client                        Run a client entity

Common options:
  -h, --help                    Print this help message

Client arguments:
  [NUMBER] [NUMBER]             The numbers of which the
                                operations are performed

The client gives some errors.

The correct way seems to be:

$ ./request_reply client 2  5
2024-09-13T18:59:05.309 [INFO] [ClientApp] Client initialized with ID: 01.0f.26.7b.0a.13.2e.e0.00.00.00.00
2024-09-13T18:59:05.309 [INFO] [main] Client running. Please press Ctrl+C to stop the Client at any time.
2024-09-13T18:59:05.312 [DEBUG] [ClientApp] Waiting for a server to be available
2024-09-13T18:59:08.036 [DEBUG] [ClientApp] Server discovered: 01.0f.26.7b.73.11.a4.7b.00.00.00.00
2024-09-13T18:59:08.111 [DEBUG] [ClientApp] Remote reply writer matched.
2024-09-13T18:59:08.111 [DEBUG] [ClientApp] Remote request reader matched.
2024-09-13T18:59:08.111 [DEBUG] [ClientApp] One server is available. Waiting for some time to ensure matching on the server side
2024-09-13T18:59:09.112 [INFO] [ClientApp] Request sent with ID '1': '2 + 5'
2024-09-13T18:59:09.112 [INFO] [ClientApp] Request sent with ID '2': '2 - 5'
2024-09-13T18:59:09.112 [INFO] [ClientApp] Request sent with ID '3': '2 * 5'
2024-09-13T18:59:09.112 [INFO] [ClientApp] Request sent with ID '4': '2 / 5'
2024-09-13T18:59:09.119 [INFO] [ClientApp] Reply received from server 01.0f.26.7b.73.11.a4.7b.00.00.00.00 to request with ID '1' with result: '7'
2024-09-13T18:59:09.119 [INFO] [ClientApp] Reply received from server 01.0f.26.7b.73.11.a4.7b.00.00.00.00 to request with ID '2' with result: '-3'
2024-09-13T18:59:09.119 [INFO] [ClientApp] Reply received from server 01.0f.26.7b.73.11.a4.7b.00.00.00.00 to request with ID '3' with result: '10'
2024-09-13T18:59:09.120 [INFO] [ClientApp] Reply received from server 01.0f.26.7b.73.11.a4.7b.00.00.00.00 to request with ID '4' with result: '0'

The README needs to be updated.

JesusPoderoso Sep 13, 2024
Collaborator

Hi @allbluelai, nice catch! Thanks for the new report
This PR updates the README:

[21671] Update request reply example README #5237

allbluelai Sep 13, 2024
Author

@JesusPoderoso Thank you very much again. All my questions were properly addressed. I'll close it.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[21657] cannot build request_reply example #5231

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 1 comment 6 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

[21657] cannot build request_reply example #5231

allbluelai Sep 12, 2024

Is there an already existing issue for this?

Expected behavior

Current behavior

Steps to reproduce

Fast DDS version/commit

Platform/Architecture

Transport layer

Additional context

XML configuration file

Relevant log output

Network traffic capture

Replies: 1 comment · 6 replies

JesusPoderoso Sep 12, 2024 Collaborator

JesusPoderoso Sep 13, 2024 Collaborator

JesusPoderoso Sep 13, 2024 Collaborator

allbluelai Sep 13, 2024 Author

JesusPoderoso Sep 13, 2024 Collaborator

allbluelai Sep 13, 2024 Author

allbluelai
Sep 12, 2024

Replies: 1 comment 6 replies

JesusPoderoso
Sep 12, 2024
Collaborator

JesusPoderoso Sep 13, 2024
Collaborator

JesusPoderoso Sep 13, 2024
Collaborator

allbluelai Sep 13, 2024
Author

JesusPoderoso Sep 13, 2024
Collaborator

allbluelai Sep 13, 2024
Author