test: add tests for installing from a registry

Author: DrRataplan

commands/package/install/local.js

@@ -87,11 +87,6 @@ const options = {
     alias: 'rpc',
     describe: 'force upload over XML-RPC API',
     boolean: true
-  },
-  v: {
-    alias: 'verbose',
-    describe: 'Display more information',
-    boolean: true
   }
 }
 

commands/package/install/registry.js

@@ -17,17 +17,9 @@ export const builder = yargs => {
       string: true
     })
     .positional('package', {
-      describe: 'The NAME of the package to install',
+      describe: "The package's name or its abbrev",
       string: true
     })
-    .options({
-      v: {
-        alias: 'verbose',
-        describe: 'Display more information',
-        boolean: true
-      }
-    }
-    )
 }
 
 export async function handler (argv) {
@@ -60,15 +52,18 @@ export async function handler (argv) {
 
   const { success, result } = await installFromRepo(db, {
     publicRepoURL: registry,
-    packageName: argv.package,
-    version: argv.version
+    nameOrAbbrev: argv.package,
+    version: argv.version,
+    verbose
   })
 
   if (!success) {
-    throw new Error(`${fail} ${chalk.dim(argv.package)} > could not be installed `)
+    throw new Error(`${fail} ${chalk.dim(argv.package)} > ${result}`)
   }
 
-  logSuccess(`${chalk.dim(argv.package)} > installed ${result.version === '' ? 'latest version' : 'version ' + result.version} at ${result.target}`)
+  logSuccess(
+    `${chalk.dim(argv.package)} > installed ${result.version === '' ? 'latest version' : 'version ' + result.version} at ${result.target}`
+  )
 
   return 0
 }

modules/install-from-repo.xq

@@ -45,7 +45,7 @@ try {
                 "version": $version,
                 "target": $installation/@target/string()
             }
-        }, 
+        },
         map { "method": "json" }
     )
 }
@@ -61,7 +61,7 @@ catch * {
                 "line": $err:line-number
                 (: "column": $err:column :)
             }
-        }, 
+        },
         map { "method": "json" }
     )
 }

spec/test.js

@@ -1,21 +1,29 @@
 import { spawn } from 'node:child_process'
 
+/**
+ * Run an XST command
+ *
+ * @param   {string}   cmd     - The command
+ * @param   {string[]} cmd     - The arguments
+ * @param   {Record<string, unknown>} [options] - Any options to the command, like environment variables
+ * @returns {Promise<{stderr?: string, stdout?: string, code: number}>} The result of running the command
+ */
 export async function run (cmd, args, options) {
   return new Promise((resolve, reject) => {
     let stderr
     let stdout
     const proc = spawn(cmd, args, options)
-    proc.stdout.on('data', data => {
-      stdout ? stdout += data.toString() : stdout = data.toString()
+    proc.stdout.on('data', (data) => {
+      stdout ? (stdout += data.toString()) : (stdout = data.toString())
     })
 
-    proc.stderr.on('data', data => {
-      stderr ? stderr += data.toString() : stderr = data.toString()
+    proc.stderr.on('data', (data) => {
+      stderr ? (stderr += data.toString()) : (stderr = data.toString())
     })
-    proc.on('error', error => {
+    proc.on('error', (error) => {
       reject(error)
     })
-    proc.on('close', code => {
+    proc.on('close', (code) => {
       resolve({ stderr, stdout, code })
     })
   })
@@ -29,20 +37,22 @@ export async function runPipe (cmd1, args1, cmd2, args2, options) {
     const proc2 = spawn(cmd2, args2, options)
     proc1.stdout.pipe(proc2.stdin)
 
-    proc2.stdout.on('data', data => {
-      stdout ? stdout += data.toString() : stdout = data.toString()
+    proc2.stdout.on('data', (data) => {
+      stdout ? (stdout += data.toString()) : (stdout = data.toString())
     })
 
-    proc2.stderr.on('data', data => {
-      stderr ? stderr += data.toString() : stderr = data.toString()
+    proc2.stderr.on('data', (data) => {
+      stderr ? (stderr += data.toString()) : (stderr = data.toString())
     })
-    proc2.on('close', _ => resolve({ stderr, stdout }))
-    proc1.on('error', error => reject(error))
-    proc2.on('error', error => reject(error))
+    proc2.on('close', (_) => resolve({ stderr, stdout }))
+    proc1.on('error', (error) => reject(error))
+    proc2.on('error', (error) => reject(error))
   })
 }
 
-export const asAdmin = { env: { ...process.env, EXISTDB_USER: 'admin', EXISTDB_PASS: '' } }
+export const asAdmin = {
+  env: { ...process.env, EXISTDB_USER: 'admin', EXISTDB_PASS: '' }
+}
 export function forceColorLevel (level) {
   return { env: { ...process.env, FORCE_COLOR: level } }
 }