Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filename when pinning asset content #29

Open
SethDocherty opened this issue Sep 25, 2024 · 2 comments
Open

Add filename when pinning asset content #29

SethDocherty opened this issue Sep 25, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@SethDocherty
Copy link
Member

Extend the pin method within Assets to add a name to the created pin. This will help when trying to understand what the CID content is when viewing on the local IPFS node.

Reference: https://docs.ipfs.tech/reference/kubo/rpc/#api-v0-pin-add

@SethDocherty SethDocherty added the enhancement New feature or request label Sep 25, 2024
@matthewnanas matthewnanas self-assigned this Sep 25, 2024
@matthewnanas
Copy link
Member

Addressed in 625b42b

@SethDocherty
Copy link
Member Author

SethDocherty commented Sep 26, 2024

The next thing to work out is how we can pass in the filename when the asset object is created. It's not quite simple since we can't rely on using the value from the pgstac-asset obj, item.id, as a filename since a pgstac-asset obj can have multiple asset files.

We could specify which asset, but that may add more complexity than we want. Anyway, it is not something that needs to be resolved right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants