Move registry fully to c10 (pytorch#12077)

Summary:
This does 6 things:

- add c10/util/Registry.h as the unified registry util
  - cleaned up some APIs such as export condition
- fully remove aten/core/registry.h
- fully remove caffe2/core/registry.h
- remove a bogus aten/registry.h
- unifying all macros
- set up registry testing in c10

Also, an important note that we used to mark the templated Registry class as EXPORT - this should not happen, because one should almost never export a template class. This PR fixes that.
Pull Request resolved: pytorch#12077

Reviewed By: ezyang

Differential Revision: D10050771

Pulled By: Yangqing

fbshipit-source-id: 417b249b49fed6a67956e7c6b6d22374bcee24cf

Author: Yangqing

.jenkins/pytorch/test.sh

@@ -102,6 +102,7 @@ test_aten() {
       SUDO=sudo
     fi
 
+    ${SUDO} ln -s "$TORCH_LIB_PATH"/libc10* build/bin
     ${SUDO} ln -s "$TORCH_LIB_PATH"/libcaffe2* build/bin
     ${SUDO} ln -s "$TORCH_LIB_PATH"/libnccl* build/bin
 

aten/src/ATen/Registry.h

@@ -9,7 +9,10 @@ LegacyTypeDispatch & globalLegacyTypeDispatch() {
   return singleton;
 }
 
-AT_DEFINE_REGISTRY(LegacyTypeInitRegistry, LegacyTypeInitInterface, LegacyTypeInitArgs)
+C10_DEFINE_REGISTRY(
+    LegacyTypeInitRegistry,
+    LegacyTypeInitInterface,
+    LegacyTypeInitArgs)
 
 const LegacyTypeInitInterface& getLegacyTypeInit() {
   static std::unique_ptr<LegacyTypeInitInterface> legacy_type_init;

aten/src/ATen/core/LegacyTypeDispatch.cpp

@@ -43,8 +43,12 @@ struct CAFFE2_API LegacyTypeInitInterface {
   }
 };
 struct CAFFE2_API LegacyTypeInitArgs {};
-AT_DECLARE_REGISTRY(LegacyTypeInitRegistry, LegacyTypeInitInterface, LegacyTypeInitArgs);
-#define REGISTER_LEGACY_TYPE_INIT(clsname) AT_REGISTER_CLASS(LegacyTypeInitRegistry, clsname, clsname)
+C10_DECLARE_REGISTRY(
+    LegacyTypeInitRegistry,
+    LegacyTypeInitInterface,
+    LegacyTypeInitArgs);
+#define REGISTER_LEGACY_TYPE_INIT(clsname) \
+  C10_REGISTER_CLASS(LegacyTypeInitRegistry, clsname, clsname)
 
 CAFFE2_API const LegacyTypeInitInterface& getLegacyTypeInit();
 

aten/src/ATen/core/LegacyTypeDispatch.h

@@ -24,6 +24,9 @@ namespace detail {
 
 }
 
-AT_DEFINE_REGISTRY(VariableHooksRegistry, VariableHooksInterface, VariableHooksArgs)
+C10_DEFINE_REGISTRY(
+    VariableHooksRegistry,
+    VariableHooksInterface,
+    VariableHooksArgs)
 
 } // namespace at::detail

aten/src/ATen/core/Registry.h

@@ -1,8 +1,8 @@
 #pragma once
 
-#include <ATen/core/Registry.h>
-#include <ATen/core/ScalarType.h>
 #include <ATen/core/Backend.h>
+#include <ATen/core/ScalarType.h>
+#include "c10/util/Registry.h"
 
 namespace at {
   class LegacyTypeDispatch;
@@ -39,8 +39,12 @@ struct CAFFE2_API VariableHooksInterface {
 // for the "..." in a variadic macro"
 struct CAFFE2_API VariableHooksArgs {};
 
-AT_DECLARE_REGISTRY(VariableHooksRegistry, VariableHooksInterface, VariableHooksArgs)
-#define REGISTER_VARIABLE_HOOKS(clsname) AT_REGISTER_CLASS(VariableHooksRegistry, clsname, clsname)
+C10_DECLARE_REGISTRY(
+    VariableHooksRegistry,
+    VariableHooksInterface,
+    VariableHooksArgs);
+#define REGISTER_VARIABLE_HOOKS(clsname) \
+  C10_REGISTER_CLASS(VariableHooksRegistry, clsname, clsname)
 
 namespace detail {
 CAFFE2_API const VariableHooksInterface& getVariableHooks();

aten/src/ATen/core/VariableHooksInterface.cpp

@@ -54,6 +54,6 @@ const CUDAHooksInterface& getCUDAHooks() {
 }
 } // namespace detail
 
-AT_DEFINE_REGISTRY(CUDAHooksRegistry, CUDAHooksInterface, CUDAHooksArgs)
+C10_DEFINE_REGISTRY(CUDAHooksRegistry, CUDAHooksInterface, CUDAHooksArgs)
 
 } // namespace at

aten/src/ATen/core/VariableHooksInterface.h

@@ -2,9 +2,10 @@
 
 #include <ATen/Allocator.h>
 #include <ATen/core/Generator.h>
-#include <ATen/core/Registry.h>
 #include <ATen/core/Error.h>
 
+#include "c10/util/Registry.h"
+
 #include <cstddef>
 #include <functional>
 #include <memory>
@@ -131,9 +132,9 @@ struct CAFFE2_API CUDAHooksInterface {
 // for the "..." in a variadic macro"
 struct CAFFE2_API CUDAHooksArgs {};
 
-AT_DECLARE_REGISTRY(CUDAHooksRegistry, CUDAHooksInterface, CUDAHooksArgs)
+C10_DECLARE_REGISTRY(CUDAHooksRegistry, CUDAHooksInterface, CUDAHooksArgs);
 #define REGISTER_CUDA_HOOKS(clsname) \
-  AT_REGISTER_CLASS(CUDAHooksRegistry, clsname, clsname)
+  C10_REGISTER_CLASS(CUDAHooksRegistry, clsname, clsname)
 
 namespace detail {
 CAFFE2_API const CUDAHooksInterface& getCUDAHooks();

aten/src/ATen/detail/CUDAHooksInterface.cpp

@@ -20,6 +20,8 @@ const ComplexHooksInterface& getComplexHooks() {
 }
 } // namespace detail
 
-AT_DEFINE_REGISTRY(ComplexHooksRegistry, ComplexHooksInterface, ComplexHooksArgs)
-
+C10_DEFINE_REGISTRY(
+    ComplexHooksRegistry,
+    ComplexHooksInterface,
+    ComplexHooksArgs)
 }

aten/src/ATen/detail/CUDAHooksInterface.h

@@ -1,7 +1,7 @@
 #pragma once
 
-#include <ATen/Registry.h>
 #include <ATen/Error.h>
+#include "c10/util/Registry.h"
 
 namespace at {
 
@@ -16,9 +16,12 @@ struct CAFFE2_API ComplexHooksInterface {
 };
 
 struct CAFFE2_API ComplexHooksArgs {};
-AT_DECLARE_REGISTRY(ComplexHooksRegistry, ComplexHooksInterface, ComplexHooksArgs)
+C10_DECLARE_REGISTRY(
+    ComplexHooksRegistry,
+    ComplexHooksInterface,
+    ComplexHooksArgs);
 #define REGISTER_COMPLEX_HOOKS(clsname) \
-  AT_REGISTER_CLASS(ComplexHooksRegistry, clsname, clsname)
+  C10_REGISTER_CLASS(ComplexHooksRegistry, clsname, clsname)
 
 namespace detail {
 CAFFE2_API const ComplexHooksInterface& getComplexHooks();

aten/src/ATen/detail/ComplexHooksInterface.cpp

@@ -1,6 +1,7 @@
 #ifndef THC_NUMERICS_INC
 #define THC_NUMERICS_INC
 
+#include <cstdlib>
 #include <limits>
 #include <cuda.h>
 #include <assert.h>

aten/src/ATen/detail/ComplexHooksInterface.h

@@ -16,6 +16,9 @@ configure_file(
 # check with the core PyTorch developers as the dependendency will be
 # transitively passed on to all libraries dependent on PyTorch.
 file(GLOB_RECURSE C10_SRCS *.cpp)
+# exclude test files
+file(GLOB_RECURSE C10_ALL_TEST_FILES test/*.cpp)
+exclude(C10_SRCS "${C10_SRCS}" ${C10_ALL_TEST_FILES})
 file(GLOB_RECURSE C10_HEADERS *.h)
 add_library(c10 ${C10_SRCS} ${C10_HEADERS})
 # If building shared library, set dllimport/dllexport proper.
@@ -31,6 +34,8 @@ target_include_directories(
     $<BUILD_INTERFACE:${CMAKE_BINARY_DIR}>
     $<INSTALL_INTERFACE:include>)
 
+add_subdirectory(test)
+
 # ---[ Installation
 # Note: for now, we will put all export path into one single Caffe2Targets group
 # to deal with the cmake deployment need. Inside the Caffe2Targets set, the