Skip to content

Only import org.eclipse.tm.terminal.connector.local#1213

Merged
jonahgraham merged 1 commit into
eclipse-cdt:mainfrom
laeubi:only_import_connector_local
Jun 19, 2025
Merged

Only import org.eclipse.tm.terminal.connector.local#1213
jonahgraham merged 1 commit into
eclipse-cdt:mainfrom
laeubi:only_import_connector_local

Conversation

@laeubi

@laeubi laeubi commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

@jonahgraham jonahgraham merged commit 0bbe001 into eclipse-cdt:main Jun 19, 2025
4 checks passed
@laeubi

laeubi commented Jun 19, 2025

Copy link
Copy Markdown
Contributor Author

@jonahgraham now there is a feature on platform where I added all migrated terminal stuff I wonder if it would be an option to even delete the (then empty) features from CDT and instead use the platform one? As we likely want to adjust the EPPs as well (even though I have not found where the terminal stuff is included there) its seems a good opportunity to get rid of them with the next release.

@jonahgraham

Copy link
Copy Markdown
Member

delete the (then empty) features from CDT and instead use the platform one?

I am ok to delete empty features - but I think we need p2.inf entries to handle the (effective) renaming of the features so check for updates works for users. I do not think we need to maintain a 1-to-1 mapping for the new features. i.e. all deleted features can be remaped to org.eclipse.platform.terminal.feature

even though I have not found where the terminal stuff is included there

Main terminal feature included here for CPP (as en example, all epp.product files have the same entry). In addition some packages include the serial extension, such as cpp here

The other common place users get the terminal is from the marketplace in this entry https://marketplace.eclipse.org/content/tm-terminal/ which requires org.eclipse.tm.terminal.feature and optionally selects org.eclipse.tm.terminal.connector.cdtserial.feature and org.eclipse.tm.terminal.connector.remote.feature

@jonahgraham jonahgraham modified the milestones: 12.3.0, 12.2.0 Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants