Click here to review and test in web IDE:

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1315

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1315", name: che-dashboard}]}}]"

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1315

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1315", name: che-dashboard}]}}]"

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1315

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1315", name: che-dashboard}]}}]"

/test v14-e2e-puppeteer

Codecov Report

Attention: Patch coverage is 86.94158% with 38 lines in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (f2e8000) to head (b2cc47c).
Report is 5 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1315      +/-   ##
==========================================
+ Coverage   91.65%   91.85%   +0.20%     
==========================================
  Files         500      501       +1     
  Lines       45489    45478      -11     
  Branches     3173     3186      +13     
==========================================
+ Hits        41691    41776      +85     
+ Misses       3766     3673      -93     
+ Partials       32       29       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olexii4 : hello
FYI:

• verification of http raw devfile is not properly resolved by the User Dashboard che#23331 issue fix up has been passed.
• verification of User Dashboard showed wrong default devfile content of workspace created from private GitHub repo using SSH URL che#23301 issue fix up has been failed.

See test details below:

Test scenario to check eclipse-che/che#23331 issue fix up:

1. Install Eclipse Che Next with User Dashboard image quay.io/eclipse/che-dashboard:pr-1315
2. Open User Dashboard
3. Create workspace from URL https://gist.githubusercontent.com/ibuziuk/0a8d3896865577aa010847991d561112/raw/5a3c54d48cea3f04343d727b5ff6807d010bc5dd/devfile.yaml
4. Review workspace's Devfile in User Dashboard.

Test result:

✅ The workspace itself was created using the correct devfile from the repository.
✅ There was correct Devfile content shown in User Dashboard:

schemaVersion: 2.3.0
metadata:
  name: ubi9-minimal-demo
components:
  - attributes:
      controller.devfile.io/merge-contribution: true
    name: tools
    container:
      image: registry.access.redhat.com/ubi9-minimal:9.3-1552@sha256:582e18f13291d7c686ec4e6e92d20b24c62ae0fc72767c46f30a69b1a6198055
      args:
        - tail
        - '-f'
        - /dev/null
      endpoints:
        - exposure: public
          name: nodejs
          protocol: http
          targetPort: 3000
      memoryLimit: 2Gi
      memoryRequest: 256Mi
      mountSources: true

Test scenario to check eclipse-che/che#23301 issue fix up:

1. Install Eclipse Che Next with User Dashboard image quay.io/eclipse/che-dashboard:pr-1315
2. Open User Dashboard and add SSH Key.
3. Create workspace from private repo using SSH Git URL [email protected]:crw-qe/quarkus-api-example-private.git
4. Review workspace's Devfile in User Dashboard.

Test result:

✅ The workspace itself was created using the correct devfile from the repository.

⚠️ There was incorrect Devfile content shown in User Dashboard:

schemaVersion: 2.2.0
metadata:
  generateName: empty

Expected defile content: devfile (12).yaml.txt

Screencast: screen-capture.webm

@dmytro-ndp

Create workspace from private repo using SSH Git URL [email protected]:crw-qe/quarkus-api-example-private.git

This is a private repository, we can not fetch the devfile content having only ssh key, see: https://eclipse.dev/che/docs/stable/end-user-guide/starting-a-workspace-from-a-git-repository-url/

@dmytro-ndp From my point of view, the test scenario to check eclipse-che/che#23301 could not be properly correct because the added SSH Key allows us to use git operations after the workspace starts. So, we can create a new workspace from the private repo using SSH Git URL [email protected]:crw-qe/quarkus-api-example-private.git. A new workspace will be created from the empty.yaml because che-server resolves SSH Git URL [email protected]:crw-qe/quarkus-api-example-private.git with an error:

These changes allow us to see the original devfile used to create a new workspace.
Without changes from this PR, we had:

Now we have the original empty devfile:

So, in the case with the private repo using the SSH Git URL, we should restart the workspace from the local devfile from the che-editor side to accept the right devfile.

@vinokurig, @olexii4 : thank you for the comment

This is a private repository, we can not fetch the devfile content having only ssh key, see: https://eclipse.dev/che/docs/stable/end-user-guide/starting-a-workspace-from-a-git-repository-url/

I faced different result.
Workspaces seems to be created using correct devfile.yaml from the target repo. It could be related to the feature described in the issue eclipse-che/che#23277
See test screencast: screen-capture.webm.

@dmytro-ndp I removed eclipse-che/che#23301 from the description.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, dmytro-ndp, olexii4

The full list of commands accepted by this bot can be found here.

New changes are detected. LGTM label has been removed.

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1315

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1315", name: che-dashboard}]}}]"