fix: factory flow with a devfile that uses a parent #1320
Conversation
Signed-off-by: Oleksii Orel <[email protected]>
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1320 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1320", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1320 +/- ##
==========================================
- Coverage 91.81% 91.65% -0.17%
==========================================
Files 501 501
Lines 45535 45535
Branches 3183 3172 -11
==========================================
- Hits 41808 41733 -75
- Misses 3695 3769 +74
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Eclipse Che Next with User Dashboard quay.io/eclipse/che-dashboard:pr-1320 has successfully created workspace using Git Repo with parent devfile https://github.com/testsfactory/parentDevfile
Screencast:
screen-capture (3).webm
Well done!
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dmytro-ndp, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
This PR fixes factory flow with a devfile that uses a parent.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23353
Is it tested? How?
Release Notes
Docs PR