From 0fee91e42f4c63e80839df9d3560dca3959f2e31 Mon Sep 17 00:00:00 2001 From: Tobias Ortmayr Date: Fri, 21 Jun 2024 12:15:16 +0200 Subject: [PATCH] Fix workflow documentation navigation example (#89) Update the NodeDocumentationNavigationTargetProvider to not rely on the tasks name which is currently unreliable (see https://github.com/eclipse-glsp/glsp/issues/1351) and instead relies on the `text` property of the tasks label. --- .../provider/node-documentation-navigation-target-provider.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/workflow-server/src/common/provider/node-documentation-navigation-target-provider.ts b/examples/workflow-server/src/common/provider/node-documentation-navigation-target-provider.ts index 50f43f1..32f8709 100644 --- a/examples/workflow-server/src/common/provider/node-documentation-navigation-target-provider.ts +++ b/examples/workflow-server/src/common/provider/node-documentation-navigation-target-provider.ts @@ -14,7 +14,7 @@ * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 ********************************************************************************/ import { Args, EditorContext, NavigationTarget } from '@eclipse-glsp/protocol'; -import { JsonOpenerOptions, ModelState, NavigationTargetProvider } from '@eclipse-glsp/server'; +import { GLabel, JsonOpenerOptions, ModelState, NavigationTargetProvider } from '@eclipse-glsp/server'; import { inject, injectable } from 'inversify'; import { TaskNode } from '../graph-extension'; @@ -28,7 +28,7 @@ export class NodeDocumentationNavigationTargetProvider implements NavigationTarg getTargets(editorContext: EditorContext): NavigationTarget[] { if (editorContext.selectedElementIds.length === 1) { const taskNode = this.modelState.index.findByClass(editorContext.selectedElementIds[0], TaskNode); - if (!taskNode || !(taskNode.id === 'task0')) { + if (!taskNode || !taskNode.children.some(child => child instanceof GLabel && child.text === 'Push')) { return []; }