Formatter and indentation

[cdietrich]

Hi,
how does formatter on indentation do determine what does on one line?

we see this behaviour

state {
		someName: Id,
		someOtherName: Id
}

formats to

state {
		someName: Id
                ,
		someOtherName: Id
}

[msujew]

Hey @cdietrich can you share some of your formatter code? Generally, adding indentation to an element automatically moves it to a new line.

[cdietrich]

entry State:
    'state' '{' content+=StateContent ( ',' content+=StateContent)* '}';


StateMember:
    name=ID ':' type=ID;

StateContent:
    StateMember;

with

export class CustomFormatter extends AbstractFormatter {
  protected format(node: AstNode): void {
    if (node.$type === "State") {
      const formatter = this.getNodeFormatter(node);
      formatBody(node, formatter);

      formatter.keyword("state").prepend(FormatingOptions.emptyLine);
      formatter
        .keywords(",")
        .append(FormatingOptions.lineBreak)
        .prepend(Formatting.noIndent())
        .prepend(Formatting.newLines(0));
    } else if (node.$type === "StateMember") {
      const formatter = this.getNodeFormatter(node);
      formatter.node(node).prepend(Formatting.indent());
    }
  }
}

it seems to work

but with

export class CustomFormatter extends AbstractFormatter {
    protected format(node: AstNode): void {
        if (node.$type === 'State') {
            const formatter = this.getNodeFormatter(node);
            formatter.keyword("state").prepend(FormatingOptions.emptyLine)
  formatter.keyword(",").append(FormatingOptions.lineBreak)
  formatBody(node, formatter)
        } else if (node.$type === 'StateMember') {
            const formatter = this.getNodeFormatter(node);
            if (node.$containerIndex !== 1) {
                formatter.node(node).prepend(FormatingOptions.indent)
            }
        }
    }
}

it does not

const FormatingOptions = {
    lineBreak: Formatting.newLine({ allowMore: true }),
    emptyLine: Formatting.newLines(2, { allowMore: true }),
    newLineAllowMore: Formatting.newLine({ allowMore: true }),
    oneSpace: Formatting.spaces(1),
    noSpace: Formatting.noSpace(),
    indent: Formatting.indent({ allowMore: true }),
    noIndent: Formatting.noIndent({ allowMore: true }),
  }

  function formatBody(_: AstNode, formatter: NodeFormatter<AstNode>) {
    const bracesOpen = formatter.keyword("{")
    const bracesClose = formatter.keyword("}")
    const interior = formatter.interior(bracesOpen, bracesClose)
  
    interior.prepend(FormatingOptions.indent)
  
    bracesClose.prepend(FormatingOptions.lineBreak)
  }