Clean Code for mylyn.builds/org.eclipse.mylyn.jenkins.core

[eclipse-mylyn-bot]

The following cleanups were applied:

• Add final modifier to private fields
• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Convert control statement bodies to block
• Make inner classes static where possible
• Remove trailing white spaces on all lines
• Remove unnecessary array creation for varargs
• Remove unnecessary suppress warning tokens
• Remove unused imports
• Remove unused private constructors
• Remove unused private fields
• Remove unused private methods
• Remove unused private types
• Replace deprecated calls with inlined content where possible
• Use pattern matching for instanceof

[github-actions]

Test Results

 1 626 files  ±0   1 626 suites  ±0   1h 32m 14s ⏱️ + 8m 33s
 5 327 tests ±0   5 241 ✅ ±0   79 💤 ±0  3 ❌ ±0   4 🔥 ±0 
13 470 runs  ±0  13 214 ✅ ±0  235 💤 ±0  9 ❌ ±0  12 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 302e518. ± Comparison against base commit c3a9151.

♻️ This comment has been updated with latest results.

[ruspl-afed]

perhaps this is needed for persistence or something similar

[ruspl-afed]

Do you know if we really need these fields @gnl42 ?

[BeckerFrank]

Yes it is used to build a json string for the Jenkins Form; but I can not find a unit test where parm is filled. So not sure if we can safely delete parts and the private Classes.

[gnl42]

What is the story on this PR?