-
Notifications
You must be signed in to change notification settings - Fork 24
Refinement of the new modern icon style #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If you agree we can focus on the Mono style with dual tonality (see Dual-Tone style) and icon enablement. One such example from the Eclipse UI Guidelines is the centering of the icons. Is there a reason why icons are not centered but have one pixel space on the top and left side? |
I don't really know what the real cause is. Maybe it's just some kind of "padding" so that there a bit of space when icons are next to each other. Maybe we can make an experiment and try out what happens if we don't leave these 1 pixel rows / columns empty. |
Yes this is a good idea. |
@IamLRBA if you want you can create a simple list of icon related requirements from the Eclipse UI Guidelines. With this I mean a listing of things like Positioning, Color Palette etc. If you don't want to create this list and want to focus on something different instead, I will provide the list as soon as I find some time. :) |
I just saw that the positioning of the icons (one pixel line space on two sides) is dependent of the type of the icon in the Eclipse UI Guidelines. The following icon shows only 2 of 4 different icon types from which 2 have the same spacing. So in total we have the 1 pixel space on the top + left (toolbar icons), bottom + left (view icons + model object icons), bottom + right (perspective icons). If we don't find a good reason why the positioning should be done this way, I would strongly advise against it. |
@Michael5601 I did some digging and here's what i found. Icon Design Guidelines for Eclipse UI1. PositioningIcons should align consistently within their designated spaces, particularly in tree views or lists. Misaligned icons create a cluttered appearance and reduce readability. 2. Color PaletteThe Eclipse-style palette uses blue and yellow as base colors, complemented by green, red, brown, purple, and beige for specific functions or object types. Consistency in color choices ensures harmony across the UI while enabling differentiation between elements. 3. Icon TypesDistinctions exist between functional, representational, and navigational icons:
4. Icon Size & PlacementStandard sizes are critical for clarity and consistency. Eclipse icons are typically designed for 16x16 pixels but must remain legible at various resolutions. Placement standards include spacing to avoid visual clutter. 5. Enablement StatesIcons should visually indicate their states, such as active, inactive, or disabled. Techniques include using grayscale for disabled icons or applying slight opacity changes. This is crucial for user feedback and accessibility. 6. OverlaysOverlays provide additional contextual information, such as a small arrow to signify a shortcut. They should be clear and not obscure the main icon’s function. 7. ConsistencyIcon design should adhere to established visual patterns to maintain a unified look and feel across the UI. Variations should be minimal and purposeful. 8. AccessibilityIcons must be distinguishable for users with color blindness or other visual impairments. Use patterns, shapes, and complementary design elements alongside color to enhance accessibility. 9. Prototypes and TestingBefore finalizing designs, test icons within the Eclipse environment to ensure usability in real-world scenarios. This helps refine the style guide and identify practical issues. If at all you need further refinements or additional points added to the list, let me know! |
Thank you, @Michael5601, for highlighting this issue with the current positioning rules in the Eclipse UI Guidelines. I completely agree that the varying pixel spacings based on icon type introduces unnecessary complexity and could result in misalignment issues. As mentioned in previous discussions, I'd still have those same ideas as my thoughts and suggestions to address this: Suggestions for Standardization:
Benefits of Standardization:
Let me know your thoughts! |
Thanks for the list! The second point from the list is Color Palette. My idea for this is that most icons will be monochromatic as they don't need a visual indicator. But some icons for example Actions like the
I`d say we focus on the light theme at first as all icons can be easily "recolored" automatically after they are designed monochromatically. The design is the hard part for this initiative. |
This is my proposal for a modern icon pack style guide. I redesigned the icons that won the poll and had no issues by following these rules. It would be great if you can give me feedback for this. Eclipse Modern Icon Pack Style GuideIcon TypesEvery Icon is categorized into one of three distinct types:
Color AssignmentsEach color has a specific meaning and should be applied consistently:
Icon Sizes & Placement
Standard Icons
Overlay Icons
Wizard Icons
Disabled Icon State (This point may need more discussion)Disabled icons should maintain their original form while visually indicating inactivity:
SpecificationsThis section outlines the design rules for Eclipse icons in the modern icon pack. Stroke style
Spacing
Corners
Dual-Tonality |
Do you intend to replace existing icons, or just to make this new icon set available in addition? The Eclipse IDE, all the plugins around it and the commercial products have a 25 year history, and by replacing the icons in the icon repository and in the platform code, you will not be able to standardize anything more, but rather less. It's impossible to have all external plugins and applications also update their icons. Just the change from gif extensions to png extension (many years ago) caused broken Eclipse icons for a timespan of around 3 years, until most developers had updated their code. By doing a similar (and larger) refactoring of icons, there will be even more turbulences for anyone who is not the platform project. |
The icons are meant as an addition to the existing default icons. In this PR an icon theming mechanism for Eclipse was discussed and a prototype (i think?) implemented. With such a mechanism users could change the icon theme (default, modern, flat etc.) as they want. I started this initiative for monochromatic modern icons as I worked and still work on the SVG rasterization feature in this PR. |
Icon Design for
|
Hey Jerry, Your feedback for the style guide was helpful and I already integrated it into the pull request. Here is a comparison of my changes:
Today I also designed three new icons: collapseall: copy_edit_co: disconnect_co: All of these icons are from the org.eclipse.debug.ui bundle. If you want you can freely choose icons from this bundle and create a new modern style with the style guide. I will do the same and will focus on the folder |
Thanks for the reply @Michael5601, I already started designing icons from a different folder in the bundle and will share details here soon. |
As the community poll is finished now I want to refine the icon style that will be used as a base for the new style guide.
Please see my comments to the results here.
The text was updated successfully, but these errors were encountered: