-
Notifications
You must be signed in to change notification settings - Fork 23
Missing SVG Files #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Please note that to fix the location inconsistencies the specific SVGs should not be moved but rather copied as they are needed in both locations. I will fix these issues soon. Can someone give me some information about why the GIFs from the last problem are not part of this repository? |
This PR fixes a few problems of eclipse-platform#129. All SVGs were copied from another location to resemble the structure of the folder `eclipse-png`.
This commit fixes a few problems of eclipse-platform#129. All SVGs were copied from another location to resemble the structure of the folder `eclipse-png`.
What do you mean with "last problem"? |
I mean the part "Icons that are not part of this repository but loaded at runtime of the Eclipse IDE" |
So maybe these icons may simply not yet migrated from GIF to PNG/SVG. |
I guess so, but I wanted your feedback before I started creting the SVGs. This will be a lot of work but it is mandatory for having a consistent look for the icons once the SVG feature is merged. |
So for GIFs in examples / tests I would be a bit more relaxed.. ,-) |
Yes you are right. I just wondered because they were all loaded in a standard Eclipse Application. I tried out different perspectives and all folders that I listed contain at least one icon that was loaded into Eclipse even though almost all of them are examples / tests. |
This commit fixes a few problems of eclipse-platform#129. All SVGs were copied from another location to resemble the structure of the folder `eclipse-png`.
This one is quite "criticial", as it does not even have an |
See my PRs #138 and eclipse-platform/eclipse.platform.ui#2936 |
Great, thank you @BeckerWdf! I will also integrate that SVG into the PR adding the SVGs for the containing bundle to Platform UI: |
This commit fixes a few problems of #129. All SVGs were copied from another location to resemble the structure of the folder `eclipse-png`.
For the SVG rasterization feature that was introduces in this PR we need to add a SVG image file for every raster image file (e.g. .png or .gif).
The following icons are not available as SVGs yet and must to be created before they can be added to the specific bundle.
Platform-bundles
themes
folderPlatform-UI-bundles
Mylyn-Bundles
JDT-Debug-Bundles
JDT-UI-Bundles
PDE-Bundles
M2E-Bundles
Equinox-Bundles
Icons of Test or Example bundles that are persisted as GIF
In addition to all icons listed above I want to mention that many example/test bundles also do not have related SVGs for their icons. This is probably fine as they are only used in development. The following list contains some examples:
eclipse.platform\runtime\bundles\org.eclipse.core.tools\icons
eclipse.platform.ui\examples\org.eclipse.ui.examples.job\icons
eclipse.platform.ui\tests\org.eclipse.ui.tests\icons
eclipse.platform.ui\examples\org.eclipse.ui.examples.contributions\icons
eclipse.platform.ui\examples\org.eclipse.ui.examples.readmetool\icons\obj16
eclipse.platform.ui\examples\org.eclipse.ui.examples.contributions\icons
eclipse.platform.ui\tests\org.eclipse.ui.tests.views.properties.tabbed\icons
The text was updated successfully, but these errors were encountered: