Skip to content

Missing SVG Files #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
38 of 85 tasks
Michael5601 opened this issue Mar 3, 2025 · 10 comments
Open
38 of 85 tasks

Missing SVG Files #129

Michael5601 opened this issue Mar 3, 2025 · 10 comments
Labels
enhancement New feature or request

Comments

@Michael5601
Copy link
Contributor

Michael5601 commented Mar 3, 2025

For the SVG rasterization feature that was introduces in this PR we need to add a SVG image file for every raster image file (e.g. .png or .gif).

The following icons are not available as SVGs yet and must to be created before they can be added to the specific bundle.

Platform-bundles

  1. org.eclipse.ant.ui:
  • obj16/eclipse16
  • wizban/ant_wiz
  • wizban/export_ant_wiz
  1. org.eclipse.ui.intro:
  • etool16/restore_welcome.svg
  1. org.eclipse.ui.intro.universal:
  • SVGs in the themes folder
  1. org.eclipse.platform:
  • all icons in images folder (see PR for proposed deletion of these SVGs.)
  1. org.eclipse.debug.ui.launchview:
  • coverage.svg
  • delete_exc.svg
  • favorite_star.svg
  1. org.eclipse.debug.ui:
  • obj16\launchConfiguration
  • ovr16\quickaccess_debug
  • ovr16\quickaccess_profile
  • ovr16\quickaccess_run
  • wizban\adddir_wiz
  • wizban\addsrcloc_wiz
  • wizban\debug_wiz
  • wizban\editdir_wiz
  • wizban\edtsrclkup_wiz
  • wizban\export_brkpts_wizban
  • wizban\export_config_wizban
  • wizban\import_brkpts_wizban
  • wizban\import_config_wizban
  • wizban\profile_wiz
  • wizban\run_wiz
  1. org.eclipse.ui.externaltools:
  • wizban/ext_tools_wiz.svg

Platform-UI-bundles

  1. org.eclipse.ui.ide:
  • eview16/problems_view_info
  1. org.eclipse.ui.ide.application:
  • elcl16/split_horizontal.svg
  • elcl16/split_vertical.svg
  1. org.eclipse.ltk.ui.refactoring:
  • wizban/apply_rescript_wiz.svg
  • wizban/create_rescript_wiz.svg
  • wizban/show_history_wiz.svg
  1. org.eclipse.ui:
  • etool16/search.svg
  1. org.eclipse.ui.editors:
  • etool16/next_edit_pos
  1. org.eclipse.ui.workbench.texteditor:
  • elcl16/open_history.svg

Mylyn-Bundles

  1. org.eclipse.mylyn.tasks.ui:
  • wizban/banner-repository.svg
  • wizban/banner-repository-context.svg
  • wizban/banner-repository-settings.svg
  • wizban/bug-wizard.svg
  • wizban/secur_role_wiz.svg
  1. org.eclipse.mylyn.wikitext.ui:
  • org.eclipse.mylyn.internal.wikitext.ui.util.resources/missing-image.svg

JDT-Debug-Bundles

  1. org.eclipse.jdt.debug.ui:
  • obj16/groupedframe.svg
  • obj16/javastacktrace_console.svg
  • obj16/jexcept_obj.svg
  1. org.eclipse.jdt.launching.ui.macosx:
  • ctool16/exportappbundle_wiz.svg
  • wizban/exportapp_wiz.svg

JDT-UI-Bundles

  1. org.eclipse.jdt.ui:
  • etool16/move_up.svg
  • wizban/newrecord_wiz.svg

PDE-Bundles

  1. org.eclipse.pde.api.tools.ui:
  • obj16/eclipse16.svg
  1. org.eclipse.pde.spy.context:
  • splash.svg (I don't know if this is used somewhere)
  1. org.eclipse.pde.spy.core:
  • spyicon.svg
  1. org.eclipse.pde.spy.model:
  • application_lightning.svg
  1. org.eclipse.pde.spy.preferences:
  • almost all icons from this bundle. SVGs with the same name are available but they look different.
  1. org.eclipse.pde.ui:
  • bndtools/bndrun.svg
  • bndtools/bundle.svg
  • bndtools/database.svg
  • elcl16/cleanmanifest.svg
  • etool16/eclipse.svg
  • obj16/eclipse.svg
  1. org.eclipse.pde.ui.templates:
  • etool16/e4.svg
  1. org.eclipse.pde.bnd.ui:
  • arrow_down.svg
  • arrow_refresh.svg
  • connect.svg
  • connections.svg
  • disconnect.svg
  • file.svg
  • link.svg
  • loading_16x16.svg
  • locked_state.svg
  • repository_xml.svg
  • repoindex.svg
  • repository_maven.svg
  • repository_pom.svg
  • service.svg
  • star_small.svg
  • template_empty.svg
  • tick.svg
  • whiteboard.svg
  1. org.eclipse.pde.doc.user:
  • Many "icons" (PNG) that show screenshots of editors. I don't think we need SVGs for these.
  1. org.eclipse.e4.tools.emf.ui:
  • Many GIFs and some PNGs that mostly do not exist as SVGs.

M2E-Bundles

  1. org.eclipse.m2e.core.ui:
  • banner_lifecycleMappingPage.svg
  • banner_new_module.svg
  • banner_new_project.svg
  • banner_update_project.svg
  • m2eclipse48.svg

Equinox-Bundles

  1. org.eclipse.equinox.p2.ui.importexport:
  • obj16/install-handler.svg

Icons of Test or Example bundles that are persisted as GIF

In addition to all icons listed above I want to mention that many example/test bundles also do not have related SVGs for their icons. This is probably fine as they are only used in development. The following list contains some examples:

  • eclipse.platform\runtime\bundles\org.eclipse.core.tools\icons
  • eclipse.platform.ui\examples\org.eclipse.ui.examples.job\icons
  • eclipse.platform.ui\tests\org.eclipse.ui.tests\icons
  • eclipse.platform.ui\examples\org.eclipse.ui.examples.contributions\icons
  • eclipse.platform.ui\examples\org.eclipse.ui.examples.readmetool\icons\obj16
  • eclipse.platform.ui\examples\org.eclipse.ui.examples.contributions\icons
  • eclipse.platform.ui\tests\org.eclipse.ui.tests.views.properties.tabbed\icons
@Michael5601 Michael5601 added the enhancement New feature or request label Mar 3, 2025
@Michael5601
Copy link
Contributor Author

Please note that to fix the location inconsistencies the specific SVGs should not be moved but rather copied as they are needed in both locations.

I will fix these issues soon. Can someone give me some information about why the GIFs from the last problem are not part of this repository?

Michael5601 added a commit to Michael5601/eclipse.platform.images that referenced this issue Mar 3, 2025
This PR fixes a few problems of eclipse-platform#129.

All SVGs were copied from another location to resemble the structure of the folder `eclipse-png`.
Michael5601 added a commit to Michael5601/eclipse.platform.images that referenced this issue Mar 3, 2025
This commit fixes a few problems of eclipse-platform#129.

All SVGs were copied from another location to resemble the structure of the folder `eclipse-png`.
@BeckerWdf
Copy link
Contributor

Can someone give me some information about why the GIFs from the last problem are not part of this repository?

What do you mean with "last problem"?

@Michael5601
Copy link
Contributor Author

Can someone give me some information about why the GIFs from the last problem are not part of this repository?

What do you mean with "last problem"?

I mean the part "Icons that are not part of this repository but loaded at runtime of the Eclipse IDE"

@BeckerWdf
Copy link
Contributor

Can someone give me some information about why the GIFs from the last problem are not part of this repository?

What do you mean with "last problem"?

I mean the part "Icons that are not part of this repository but loaded at runtime of the Eclipse IDE"

So maybe these icons may simply not yet migrated from GIF to PNG/SVG.

@Michael5601
Copy link
Contributor Author

So maybe these icons may simply not yet migrated from GIF to PNG/SVG.

I guess so, but I wanted your feedback before I started creting the SVGs. This will be a lot of work but it is mandatory for having a consistent look for the icons once the SVG feature is merged.

@BeckerWdf
Copy link
Contributor

So maybe these icons may simply not yet migrated from GIF to PNG/SVG.

I guess so, but I wanted your feedback before I started creting the SVGs. This will be a lot of work but it is mandatory for having a consistent look for the icons once the SVG feature is merged.

So for GIFs in examples / tests I would be a bit more relaxed.. ,-)

@Michael5601
Copy link
Contributor Author

So for GIFs in examples / tests I would be a bit more relaxed.. ,-)

Yes you are right. I just wondered because they were all loaded in a standard Eclipse Application. I tried out different perspectives and all folders that I listed contain at least one icon that was loaded into Eclipse even though almost all of them are examples / tests.

Michael5601 added a commit to Michael5601/eclipse.platform.images that referenced this issue Mar 29, 2025
This commit fixes a few problems of eclipse-platform#129.

All SVGs were copied from another location to resemble the structure of the folder `eclipse-png`.
@HeikoKlare
Copy link
Contributor

HeikoKlare commented Apr 24, 2025

org.eclipse.ui.ide:

eview16/problems_view_info

This one is quite "criticial", as it does not even have an @2x version.

@BeckerWdf
Copy link
Contributor

org.eclipse.ui.ide:
eview16/problems_view_info

This one is quite "criticial", as it does not even have an @2x version.

See my PRs #138 and eclipse-platform/eclipse.platform.ui#2936

@HeikoKlare
Copy link
Contributor

Great, thank you @BeckerWdf!

I will also integrate that SVG into the PR adding the SVGs for the containing bundle to Platform UI:

HeikoKlare pushed a commit that referenced this issue Apr 24, 2025
HeikoKlare pushed a commit that referenced this issue Apr 24, 2025
This commit fixes a few problems of #129.

All SVGs were copied from another location to resemble the structure of the folder `eclipse-png`.
HeikoKlare pushed a commit to eclipse-platform/eclipse.platform.ui that referenced this issue Apr 24, 2025
@Michael5601 Michael5601 changed the title Inconsistencies and Missing SVG Files Missing SVG Files May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants