Add GTK4 to build matrix on GitHub actions #2767
Draft
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahgraham
force-pushed
the
gk4-matrix-entry
branch
from
1bddc88 to
ba8986a
Compare
Contributor
jonahgraham
force-pushed
the
gk4-matrix-entry
branch
from
ba8986a to
7ecd9b2
Compare
jonahgraham
added
runtodotests
Add a gtk build matrix entry for GTK3 and GTK4. Included is a little bit of self-documenting of the dependencies to build on Linux. Part of eclipse-platform#2714
jonahgraham
force-pushed
the
gk4-matrix-entry
branch
from
7ecd9b2 to
1d64c02
Compare
jonahgraham
commented
Nov 13, 2025
| -DskipNativeTests=false | ||
| -DfailIfNoTests=false | ||
| ${{ (inputs.runtodotests == false && contains(inputs.native, 'linux')) && '-DexcludedGroups=gtk3-todo' || '' }} | ||
| ${{ (inputs.runtodotests == false && inputs.gtk == 'gtk4') && '-DexcludedGroups=gtk4-todo' || '' }} |
Contributor
Author
There was a problem hiding this comment.
There are no tests currently tagged with gtk3-todos which is a good thing as GTK3 on x11 should be well covered.
There are some gtk3-wayland-todo tags, which are excluded in the next PR #2768
Contributor
Author
|
GTK4 on x11 tests seem stable enough (with the gtk4-todo exclusion tags). GTK4 on Wayland (and even GTK3 on Wayland) is more unstable testing. The wayland part of the matrix is a separate PR #2768 I think we are ready to submit this one, but I will wait until tomorrow in case anyone has any objections/concerns. |
6 tasks
Contributor
Author
|
I'm going to hold off on this until after we branch for this release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included is a little bit of self-documenting of the dependencies to build on Linux.
Part of #2714
In draft until dependent PR #2765 is merged.