Handled Menu Item Contributions to ShowInMenu do not evaluate Visible-When Expression

[r-mennig]

Handled Menu Items contributed to the "ShowIn"-Menu do not evaluate Visible-When Expressions. Because of this problem, entries in the "ShowIn"-Menu can be disabled, but cannot be made invisible.

• I verified I can reproduce this issue against latest Integration Build of Eclipse SDK

Steps to reproduce

Reproducing this problem inside the workspace requires additional PDE bundles (in order to create and modify a new E4 model fragment).

Since this is a E4 problem, the easiest reproduction I found for this is by modifying the "org.eclipse.e4.ui.examples.e4editor" test bundle and adding this bundle to my run configuration:

1. Open the E4 fragment editor for /org.eclipse.e4.ui.examples.e4editor/fragment.e4xmi
2. Add a new menu contribution with parent-ID org.eclipse.ui.menus.showInMenu
3. Add a new handled menu item with a matching command and handler and connect them to each other
4. Add a imperative expression for the menu item
5. Create a new handler class which implements (at)Evaluate, (at)CanExecute and (at)Execute as follows (both the handled menu item and the imperative expression must point to this class):

6. Add the "org.eclipse.e4.ui.examples.e4editor" bundle to a run configuration and start the application
7. Inside the runtime application, create a new project and open the "ShowIn"-menu (via the context menu) -> The problem occurs: The added menu item is show as disabled although the imperative expression we've added for this item should make it invisible (since the "Evaluate" method of our handler always returns false)

For comparison: Change the parent-ID of the handled menu item to "popup" and restart the application -> The item is now an invisible entry in the popup menu (can be tested via breakpoints or by changing the "Evaluate" method to return true).

Note: I've tried fixing this issue as a PR but stopped, since it looks like fixing this would require a bigger change in the way the "ShowIn"-Menu is filled. As far as I can tell the root cause for this problem seems to be inside org.eclipse.ui.internal.ShowInMenu.fillMenu(IMenuManager). Here, the handled menu items get converted to CommandContributionItem without considering if a visibleWhen-Expression is present on the item.

Community

• I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.

[iloveeclipse]

I've tried fixing this issue as a PR but stopped, since it looks like fixing this would require a bigger change in the way the "ShowIn"-Menu is filled

I assume if you want this ticket to be fixed, you should continue with the PR.

[r-mennig]

I've tried fixing this issue as a PR but stopped, since it looks like fixing this would require a bigger change in the way the "ShowIn"-Menu is filled

I assume if you want this ticket to be fixed, you should continue with the PR.

Thank you for the quick feedback! I'll try to continue with the PR 👍

[r-mennig]

I've also found an easy way to reproduce this problem inside the workspace with the latest SDK I-Build:

1. Unzip and import the project testProject.zip into an empty workspace. The projects contains the menu contributions described above for both the popup and showIn menu.
2. Create a run configuration for the SDK IDE with this project and launch the application
3. Inside the runtime application, create a new project and open the context menu -> The error occurs: The handled menu item added to the popup menu is invisible, the item added to the "showIn"-menu is disabled (since only the (at)CanExecute method is evaluated for this item)