diff --git a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDescriptor.java b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDescriptor.java index c2f3282e3e9..23eae314c9a 100644 --- a/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDescriptor.java +++ b/bundles/org.eclipse.jface/src/org/eclipse/jface/resource/ImageDescriptor.java @@ -424,30 +424,32 @@ public Image createImage(boolean returnMissingImageOnError, Device device) { */ public ImageData getImageData(int zoom) { if (zoom == 100) { - return getImageData(100); + return getImageData(); } return null; } /** - * Creates and returns a new SWT ImageData object - * for this image descriptor. - * Note that each call returns a new SWT image data object. + * Creates and returns a new SWT ImageData object for this image + * descriptor. Note that each call returns a new SWT image data object. *

- * This framework method is declared public so that it is - * possible to request an image descriptor's image data without - * creating an SWT image object. + * This framework method is declared public so that it is possible to request an + * image descriptor's image data without creating an SWT image object. *

*

* Returns null if the image data could not be created. *

*

- * This method was abstract until 3.13. Clients should stop re-implementing - * this method and should re-implement {@link #getImageData(int)} instead. + * This method was abstract until 3.13. Clients should stop re-implementing this + * method and should re-implement {@link #getImageData(int)} instead. *

* * @return a new image data or null - * @deprecated Use {@link #getImageData(int)} instead. + * @deprecated Replace with {@link #getImageData(int)} instead. Note: Calling + * this method may result in stack overflow if subclass doesn't + * override either {@link #getImageData()} or + * {@link #getImageData(int)} to prevent endless cycle between the 2 + * implementation in this class since 2017. */ @Deprecated public ImageData getImageData() {