From 2b8ab6d4f89925b22fd86378c2341407091f6459 Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Wed, 22 Apr 2026 11:53:42 +0200 Subject: [PATCH] Read splash shell title directly from the product in IDEApplication IDEApplication.start set the splash shell's taskbar title via ChooseWorkspaceDialog.getWindowTitle(). That helper is scoped to the workspace chooser dialog: it returns Platform.getProduct().getName(), and falls back to an IDEWorkbenchMessages string whose name (ChooseWorkspaceDialog_defaultProductName) is tied to the chooser dialog's presentation. Using it for the splash shell is a layering inversion. The splash is a property of the application, not of the chooser dialog, and the dialog-specific NLS fallback is not appropriate for the splash taskbar entry. Read Platform.getProduct().getName() directly in IDEApplication. If no product is configured, leave the launcher's default title in place rather than substituting a chooser-dialog placeholder. ChooseWorkspaceDialog.getWindowTitle() is retained as an internal helper for the dialog itself. No user-visible change for Eclipse IDE products, which always have a product name configured. --- .../ui/internal/ide/application/IDEApplication.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java b/bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java index 77bb2dbda2c..777deec1e69 100644 --- a/bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java +++ b/bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEApplication.java @@ -166,11 +166,13 @@ public Object start(IApplicationContext appContext) throws Exception { // look and see if there's a splash shell we can parent off of Shell shell = WorkbenchPlugin.getSplashShell(display); if (shell != null) { - // should should set the icon and message for this shell to be the - // same as the chooser dialog - this will be the guy that lives in - // the task bar and without these calls you'd have the default icon - // with no message. - shell.setText(ChooseWorkspaceDialog.getWindowTitle()); + // Set the taskbar title and icon for the splash shell. The title + // is taken from the configured product; if no product is set, the + // launcher's default title is kept. + IProduct product = Platform.getProduct(); + if (product != null && product.getName() != null) { + shell.setText(product.getName()); + } shell.setImages(Window.getDefaultImages()); }