Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagram crash when too many layoutDiagram are sent too quickly #4571

Open
frouene opened this issue Feb 17, 2025 · 0 comments · May be fixed by #4572
Open

Diagram crash when too many layoutDiagram are sent too quickly #4571

frouene opened this issue Feb 17, 2025 · 0 comments · May be fixed by #4572
Assignees
@frouene
Labels
package: diagrams type: bug
Milestone
2025.2.0

Comments

@frouene
Copy link
Contributor

frouene commented Feb 17, 2025

For each node move, a layoutDiagram mutation is sent to the backend.
But if a new mutation is sent before the first one is complete, this can cause the diagram to crash and become unusable.

This scenario can easily be reproduced by moving a node with the arrow keys.

Image
@frouene frouene added this to the 2025.2.0 milestone Feb 17, 2025
@frouene frouene self-assigned this Feb 17, 2025
frouene pushed a commit that referenced this issue Feb 17, 2025
@mcharfadi @frouene
[4571] Add debounce on synchronizeLayoutData
b237dbe 
Bug: #4571
Signed-off-by: Michaël Charfadi <[email protected]>
Signed-off-by: Florian ROUËNÉ <[email protected]>
@frouene frouene linked a pull request Feb 17, 2025 that will close this issue
Open
39 tasks
@frouene frouene linked a pull request Feb 17, 2025 that will close this issue
[4571] Add debounce on synchronizeLayoutData #4572
Open
39 tasks
frouene pushed a commit that referenced this issue Feb 17, 2025
@mcharfadi @frouene
[4571] Add debounce on synchronizeLayoutData
bc51083 
Bug: #4571
Signed-off-by: Florian ROUËNÉ <[email protected]>
frouene pushed a commit that referenced this issue Feb 17, 2025
@mcharfadi @frouene
[4571] Add debounce on synchronizeLayoutData
669c66e 
Bug: #4571
Signed-off-by: Florian ROUËNÉ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frouene frouene

Labels
package: diagrams type: bug
Projects
None yet
Milestone
2025.2.0
Development

Successfully merging a pull request may close this issue.

[4571] Add debounce on synchronizeLayoutData eclipse-sirius/sirius-web
1 participant
@frouene