Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split DiagramContext in 2 contexts #4577

Open
mcharfadi opened this issue Feb 17, 2025 · 0 comments · May be fixed by #4579
Open

Split DiagramContext in 2 contexts #4577

mcharfadi opened this issue Feb 17, 2025 · 0 comments · May be fixed by #4579
Assignees
@mcharfadi
Labels
difficulty: starter package: diagrams type: performance
Milestone
2025.2.0

Comments

@mcharfadi
Copy link
Contributor

DiagramContext is used in many hooks but the values of refreshEventPayloadId and payload changes with each refresh making all component that uses theses hooks to rerender.
@mcharfadi mcharfadi added this to the 2025.2.0 milestone Feb 17, 2025
@mcharfadi mcharfadi self-assigned this Feb 17, 2025
mcharfadi added a commit that referenced this issue Feb 17, 2025
@mcharfadi
[4577] Add DiagramPayloadContext and remove payload from DiagramContext
f7ae2ad 
Bug: #4577
Signed-off-by: Michaël Charfadi <[email protected]>
@mcharfadi mcharfadi linked a pull request Feb 17, 2025 that will close this issue
Open
39 tasks
@mcharfadi mcharfadi linked a pull request Feb 17, 2025 that will close this issue
[4577] Add DiagramPayloadContext and remove payload from DiagramContext #4579
Open
39 tasks
mcharfadi added a commit that referenced this issue Feb 17, 2025
@mcharfadi
[4577] Add DiagramPayloadContext and remove payload from DiagramContext
4b10977 
Bug: #4577
Signed-off-by: Michaël Charfadi <[email protected]>
mcharfadi added a commit that referenced this issue Feb 17, 2025
@mcharfadi
[4577] Add DiagramPayloadContext and remove payload from DiagramContext
40b8611 
Bug: #4577
Signed-off-by: Michaël Charfadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcharfadi mcharfadi

Labels
difficulty: starter package: diagrams type: performance
Projects
None yet
Milestone
2025.2.0
Development

Successfully merging a pull request may close this issue.

[4577] Add DiagramPayloadContext and remove payload from DiagramContext eclipse-sirius/sirius-web
1 participant
@mcharfadi