Menu Action closes when pressing Enter.

[VilikNakhshikyan]

I have my custom Theia application and I added a new menu item to it using registerMenuAction.

Theia closes my menu when I press Enter, Is there a way to unregister this Keybinding.

[msujew]

Hey @VilikNakhshikyan,

I believe when pressing Enter, you're not exactly triggering a keybinding (we don't have a general one that triggers on Enter), but either something in Phosphor.js (soon to be replaced with Lumino) or something in the DOM API. Both of which we don't have any control over.

[VilikNakhshikyan]

I have registered theia dialog to my menu item and pressing enter closes the theia dialog even if the mouse is not on the 'close' button of theia dialog.

Do you have any ideas?

[msujew]

Oh, ok. Please give a bit more context next time. We have some special handling for key events on dialogs. See:

theia/packages/core/src/browser/dialogs.ts

Lines 247 to 252 in acaa3df

	protected handleEnter(event: KeyboardEvent): boolean | void {
	if (event.target instanceof HTMLTextAreaElement) {
	return false;
	}
	this.accept();
	}

You will likely need to overwrite this method to change the behavior in your dialog.

[VilikNakhshikyan]

Thank you very much the problem was solved. Next time I will be more detailed. :)