SourceBasedJdtTypeProviderTest permanently fails on latest

[cdietrich]

now SourceBasedJdtTypeProviderTest permanently fails on latest.
question is what has changed on plaform/jdt/pde

[cdietrich]

testcase

	@Test
	public void testFindTypeByName_$StartsWithDollar_01() {
		//		Class<org.eclipse.xtext.common.types.testSetups.$StartsWithDollar> clazz = org.eclipse.xtext.common.types.testSetups.$StartsWithDollar.class;
		String typeName = "org.eclipse.xtext.common.types.testSetups.$StartsWithDollar";
		JvmGenericType type = (JvmGenericType) getTypeProvider().findTypeByName(typeName);
		doTestFindTypeByName_$StartsWithDollar(type);
	}

[cdietrich]

@szarnekow am not sure how easy we would be able to adjust to new behaviour

fragment: org.eclipse.xtext.common.types.testSetups$$StartsWithDollar

[cdietrich]

[cdietrich]

org.eclipse.xtext.common.types.access.jdt.TypeURIHelper.createFragmentForClass(String, StringBuilder)

[cdietrich]

created #3710 to unblock

[jjohnstn]

It appears that other code is not prepared for leaving the dollar in the class name. I have tweaked the logic to still leave the dollar symbols in package names, but to use the old logic for the last segment. This allows the tests here to pass and still fixes the original problem whereby organize import wasn't creating proper imports when dollar symbols were part of the package name. I have posted a PR: eclipse-jdt/eclipse.jdt.core#5073